Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Fix and enchance Fulfillment and FulfillmentOrder after breaking changes of 2022-07 - #652

Closed
gmonacho wants to merge 9 commits into
Shopify:masterfrom
dropix-org:path-fulfillment-2022-07
Closed

gmonacho wants to merge 9 commits into
Shopify:masterfrom
dropix-org:path-fulfillment-2022-07

Conversation

@gmonacho

@gmonacho gmonacho commented Apr 26, 2023 •

Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #634

The _prefix_source being set to "/orders/$order_id/" in the Fulfillment and FulfillmentOrder classes, combined with the deprecation of the old order's fulfillment resource that entered a breaking state in 2022-07, has led to errors when using some of the Fulfillment endpoints. For more details, refer to the Shopify Changelogs.

WHAT is this pull request doing?

  • Fixing 2022-07 breaking changes
  • Enable the use of both every Fulfillment and FulfillmentOrders endpoints, which was not possible.
  • Remove FulfillmentV2 and transfer the update_tracking method from FulfillmentV2 to Fulfillment, as it is no longer necessary due to the removal of the _prefix_source attribute definition. Refer to this Pull Request for more information.

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

Saucisse à roulettes added 3 commits April 26, 2023 17:16
…hod to allow to use both /orders/ prefixed fulfillment endpoints and none prefixed fulfillment endpoints.
…x method to allow to use both /orders/ prefixed FulfillmentOrder endpoints and none prefixed FulfillmentOrder endpoints.
…method to fulfillment because it is no more needed since i have removed _prefix_source attribute definition.
@gmonacho gmonacho changed the title [WIP] Fix and enchance Fulfillment and FulfillmentOrder after breaking changes of 2022-07 Fix and enchance Fulfillment and FulfillmentOrder after breaking changes of 2022-07 Apr 26, 2023
@gmonacho

Copy link
Copy Markdown
Author

Please let me know if I have misunderstood the functionality of the _prefix_source and base _prefix methods.
I am currently testing my modifications.

Saucisse à roulettes added 3 commits April 26, 2023 19:09
…lowing specifying optional and mutliple prefix sources
…lowing specifying optional and mutliple prefix sources
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect URL generated when creating fulfillment records - API version 2023-01

1 participant