Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Add support for finding orders using customer_id - #466

Merged
Paulinakhew merged 4 commits into
masterfrom
paulinakhew-get-orders-using-customer-id
Feb 26, 2021
Merged

Paulinakhew merged 4 commits into
masterfrom
paulinakhew-get-orders-using-customer-id

Conversation

@Paulinakhew

@Paulinakhew Paulinakhew commented Feb 23, 2021 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

WHAT is this pull request doing?

  • this PR adds support for this endpoint
GET /admin/api/2021-01/customers/207119551/orders.json

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@mllemango mllemango left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note that shopify_api currently has a different setup where customer/id/orders is part of the Customer resource. This aligns with how our doc shows it, but the method itself actually fails to hit the correct endpoint (it hits /orders.json?customer_id=id).

@paulomarg paulomarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This branch had an error being deployed

1 failed deployment
pypi — 006e3e64 Deployed Apr 9, 2024 by shopify-shipit[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shopify.Order.find for list of customer_ids

4 participants