This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
Add update_tracking endpoint to Fulfillment #432
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow the idea of the
V2nomenclature, is there a particular reason we can't just do this inFulfillment? If the class is absolutely necessary, we might want to consider renaming it to something that better conveys what it does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we can do it in the original
Fulfillmentclass because that class points to/orders/$order_id/fulfillment/$fulfillment_id, and the endpoint in this case is onlyfulfillment/$fulfillment_id. I would also prefer to do it in 1 class, but I'm not quite sure how..The
V2nomenclature is from shopify_api (that is used by Fulfillment.rb) in a similar manner. Thought I would keep it consistent between the two libsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of that makes perfect sense, thanks for the context! I'm still not a fan of calling it
V2but I agree we should keep them consistent.Not saying we should do this, but I wonder if it wouldn't be cleaner to change
_prefix_sourcefor that particular method rather than adding a whole new class for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried manipulating
_prefix_sourcebut wasn't successful with my attempt. I do believe the convention of changing prefixes is to override the classmethod_prefixdepending on passed in options, but in this case the usage is after we define a Fulfillment object already :/Thus new class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with this approach, I was just thinking aloud there!