Skip to content

Feature/blip energy driftcorrection production version - #952

Merged
aantonakis merged 9 commits into
production/sbnd-gen2from
feature/BlipEnergyDriftcorrection_ProductionVersion
Nov 17, 2026
Merged

aantonakis merged 9 commits into
production/sbnd-gen2from
feature/BlipEnergyDriftcorrection_ProductionVersion

Conversation

@Jjm321814

Copy link
Copy Markdown
Contributor

Copy of the relevant portion of PR 941 #941 for Production version.
I need to check this version runs without the other develop changes.

@Jjm321814

Copy link
Copy Markdown
Contributor Author

The full array of related PR are
sbndcode: #952
sbncode: SBNSoftware/sbncode#669
sbnanaobj: SBNSoftware/sbnanaobj#198
sbnobj: SBNSoftware/sbnobj#177

@Jjm321814

Copy link
Copy Markdown
Contributor Author

The PRs compile together. Will check output of a reco2/caf stage processing

@Jjm321814

Copy link
Copy Markdown
Contributor Author

Confirmed we get the new variables out in the CAFs and the energy values are very mildly increased as expected.
This test was on 1 off-beam + light data file from gen2 reco1 production.

@linyan-w linyan-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval from me. Ready to merge to gen2 when the dev version is approved & merged!

@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Gen2 Production Aug 3, 2026
@Jjm321814

Jjm321814 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

This PR should be ready now. I'll merge in the production branch changes for the other repos

@Jjm321814

Copy link
Copy Markdown
Contributor Author

All 4 PR should be ready now

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@linyan-w linyan-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the dev comments are addressed in this version, I approve and we should merge.

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for LArSoft Failed at phase build LArSoft on slf7 for e28:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build LArSoft phase logs

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis
aantonakis merged commit 4fe096a into production/sbnd-gen2 Nov 17, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on Reviewer

Development

Successfully merging this pull request may close these issues.

4 participants