Repository navigation
Feature/blip energy driftcorrection production version - #952
aantonakis merged 9 commits into
Conversation
|
The full array of related PR are |
|
The PRs compile together. Will check output of a reco2/caf stage processing |
|
Confirmed we get the new variables out in the CAFs and the energy values are very mildly increased as expected. |
linyan-w
left a comment
There was a problem hiding this comment.
Tentative approval from me. Ready to merge to gen2 when the dev version is approved & merged!
|
This PR should be ready now. I'll merge in the production branch changes for the other repos |
|
All 4 PR should be ready now |
…ction_ProductionVersion
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
linyan-w
left a comment
There was a problem hiding this comment.
Given the dev comments are addressed in this version, I approve and we should merge.
…ction_ProductionVersion
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
❌ CI build for LArSoft Failed at phase build LArSoft on slf7 for e28:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build LArSoft phase logs |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Copy of the relevant portion of PR 941 #941 for Production version.
I need to check this version runs without the other develop changes.