Skip to content

Rollup fcls for MCP2021C testing - #231

Merged
pgreen135 merged 6 commits into
release/SBN2021Cfrom
feature/hlay_production_rollup_fcls
Nov 26, 2021
Merged

pgreen135 merged 6 commits into
release/SBN2021Cfrom
feature/hlay_production_rollup_fcls

Conversation

@henrylay97

Copy link
Copy Markdown
Member

This PR adds the fcls required to test rollup being turned off, and further turning off mcreco as discussed in #230.

@pgreen135

Copy link
Copy Markdown
Member

are these additional fhicls sufficient for production testing? there are various other workflows that inherit the standard_g4 fhicls that wouldn't pick this up -- e.g. the dirt workflows, PDS ones, commissioning ones

@henrylay97

Copy link
Copy Markdown
Member Author

This is a really good point, sorry! Has anyone got a list of the fcls intended to be used in this production?

@miquelnebot

miquelnebot commented Nov 26, 2021 •

Copy link
Copy Markdown
Contributor

I think Joseph had a list of request on his talk, but not sure about the exact fcls.

@pgreen135

Copy link
Copy Markdown
Member

discussing with @henrylay97, the plan is to merge this into today's release as is to enable testing of the core workflows on Monday. Then next week there will be a followup patch with the full set of configurations pending the results from the testing / input from US people (some workflows may need MCReco etc.).

@pgreen135
pgreen135 changed the base branch from develop to release/SBN2021C November 26, 2021 11:07
@pgreen135
pgreen135 merged commit 1d4ce74 into release/SBN2021C Nov 26, 2021
@jzennamo

Copy link
Copy Markdown
Contributor

Thank you, this was exactly what we needed, I have started testing now and I can work on getting patch fcls in place based on these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants