Skip to content

Add fhicl files for production (PDS) - #223

Merged
pgreen135 merged 2 commits into
developfrom
feature/fnicolas_decofhicl
Nov 18, 2021
Merged

pgreen135 merged 2 commits into
developfrom
feature/fnicolas_decofhicl

Conversation

@fjnicolas

Copy link
Copy Markdown
Contributor

This PR adds fhicl files for MC Production (PDS deconvolution testing samples).

@jzennamo

Copy link
Copy Markdown
Contributor

trigger build

@jzennamo

Copy link
Copy Markdown
Contributor

@fjnicolas this looks great! Could you include a reference to how this new workflow changes the expected physics results and how it changes the run time, memory, and file sizes? Thanks!

] No newline at end of file
]

physics.producers.opdecopmt.OpDecoAlg.OpDetDataFile: "OpDetSim/digi_pmt_sbnd_v2int0.root"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this file live? sbndata?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's in sbnd_data from v01_08_00. It contains a modified SER for the PMTs.

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@fjnicolas

Copy link
Copy Markdown
Contributor Author

@fjnicolas this looks great! Could you include a reference to how this new workflow changes the expected physics results and how it changes the run time, memory, and file sizes? Thanks!

  • I don't expect run time, memory and file size to change for DetSim stage. It completely changes the PMT output waveforms (switch to bipolar/with overshoot signals, aka test bench SER).
  • For Reco1 it takes ~5 extra seconds to run the opdecopmt stage. Memory usage is similar for both workflows. Below the processing summary for 5 nu+cosmic events on gpvms.

Run time and memory usage for modified workflow including PMT deconvolution (only showing PDS related processes):
numucosmic_Reco1_PMTdeco copia
numucosmic_Reco1_PMTdeco copia 2

For standard Reco1:
numucosmic_Reco1_standard copia
numucosmic_Reco1_standard copia 2

Reco1 file sizes:

  • Deconvolution: 226 MB
  • Standard: 158 MB

NB: file sizes when running standard_reco1_deco_savewf_sbnd.fcl which saves both raw and deconvolved waveforms (for debugging purposes with the MC test sample). If we don't save the waveforms I don't expect the file sizes to change significantly.

Previous studies showed a PE recovering resolution ~5% and unbiased at the level of 5% at the OpHit level. A summary can be found in docdb-22541.

@pgreen135
pgreen135 merged commit 0cac85a into develop Nov 18, 2021
@pgreen135
pgreen135 deleted the feature/fnicolas_decofhicl branch December 7, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants