Skip to content

transfer code from old feature branch - #171

Merged
pgreen135 merged 2 commits into
release/SBN2021Cfrom
feature/mstancar_CRT_T0
Nov 26, 2021
Merged

pgreen135 merged 2 commits into
release/SBN2021Cfrom
feature/mstancar_CRT_T0

Conversation

@mstancar

@mstancar mstancar commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@pgreen135

pgreen135 commented Sep 1, 2021 •

Copy link
Copy Markdown
Member

This PR contains a tidied up version of the updates in #169.

Description copied from there:

Updates to the CRT hit - TPC track matching algorithm that were described in docdb 22851

@wesketchum

Copy link
Copy Markdown
Contributor

I think this requires #143 completed in order to appropriately test prior to merge. In the meantime, we should make sure it doesn't follow too far behind develop.

@pgreen135 can we update this against develop this week, to be sure we don't get too far behind. Also, a test build may then be warranted?

@pgreen135

Copy link
Copy Markdown
Member

@wesketchum yes can do

@wesketchum

Copy link
Copy Markdown
Contributor

I think we may be getting closer to having the CRT issues fixed.

@pgreen135 can we update this against develop? If not successful, we'll need to spend some time to resolve any issues...

@pgreen135

Copy link
Copy Markdown
Member

@wesketchum done, no conflicts. Let me know when this is ready to be merged

@pgreen135

Copy link
Copy Markdown
Member

and builds successfully too!

@wesketchum

Copy link
Copy Markdown
Contributor

I'm assigning this to @mstancar and @ilepetic for the moment, just to encourage that this be tested once the other CRT fixes are in place for SBND.

@pgreen135

Copy link
Copy Markdown
Member

I believe this is now ready to be merged as the CRT fixes are in place, shall I change this from being a draft or is there still additional work to be done?

@wesketchum

Copy link
Copy Markdown
Contributor

@pgreen135 I believe that is the case! When you can, please update this to a real PR and let's get it in!

@pgreen135
pgreen135 marked this pull request as ready for review November 22, 2021 17:23
@pgreen135

Copy link
Copy Markdown
Member

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@pgreen135

Copy link
Copy Markdown
Member

This is failing the unit tests with the following error:

43: %MSG-s ArtException:  PostEndJob 22-Nov-2021 11:37:39 CST ModuleEndJob
44: ---- EventProcessorFailure BEGIN
45:   EventProcessor: an exception occurred during current event processing
46:   ---- DictionaryNotFound BEGIN
47:     No dictionary found for the following classes:
48:     
49:          art::Assns<anab::T0,sbn::crt::CRTHit,void>
50:          art::Assns<sbn::crt::CRTHit,anab::T0,void>
51:          art::Wrapper<art::Assns<anab::T0,sbn::crt::CRTHit,void> >
52:          art::Wrapper<art::Assns<sbn::crt::CRTHit,anab::T0,void> >
53:     
54:     Most likely they were never generated, but it may be that they were generated in the wrong package.
55:     
56:     Please add (or move) the specification
57:     
58:          <class name="MyClassName"/>
59:     
60:     to the appropriate classes_def.xml file.
61:     
62:     Also, if this class has any transient members,
63:     you need to specify them in classes_def.xml.
64:   ---- DictionaryNotFound END
65: ---- EventProcessorFailure END
66: %MSG

@wesketchum

Copy link
Copy Markdown
Contributor

On it ...

@etyley

etyley commented Nov 22, 2021

Copy link
Copy Markdown
Member

There is an associated sbnobj branch: https://github.com/SBNSoftware/sbnobj/tree/feature/mstancar_CRTtimetag/sbnobj

@pgreen135

Copy link
Copy Markdown
Member

thanks @etyley, can either you or @mstancar make a PR for that branch too then

@pgreen135

Copy link
Copy Markdown
Member

trigger build SBNSoftware/sbnobj#34

1 similar comment
@pgreen135

Copy link
Copy Markdown
Member

trigger build SBNSoftware/sbnobj#34

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@jzennamo
jzennamo requested a review from wesketchum November 22, 2021 23:10
@etyley

etyley commented Nov 23, 2021

Copy link
Copy Markdown
Member

The warnings in product sizes are expected due to the harsher cuts being placed on the CRT-TPC matching and additional association between the T0 and the CRT hit

@pgreen135

Copy link
Copy Markdown
Member

great, thanks @etyley

from my side this looks ready to go -- does this want to be merged into the SBN2021C branch (to be included in the next patch) or just to develop? @wesketchum

@jzennamo

Copy link
Copy Markdown
Contributor

I would vote it gets merged into SBN2021C branch (and develop), thanks everyone!

@jzennamo
jzennamo self-requested a review November 23, 2021 15:21
@pgreen135
pgreen135 changed the base branch from develop to release/SBN2021C November 23, 2021 15:22
@pgreen135

Copy link
Copy Markdown
Member

okay, I've updated these PRs (sbnobj too) to point towards the SBN2021C branches

@jzennamo
jzennamo removed the request for review from wesketchum November 23, 2021 15:28
@pgreen135
pgreen135 merged commit b6558a7 into release/SBN2021C Nov 26, 2021
@pgreen135
pgreen135 deleted the feature/mstancar_CRT_T0 branch December 7, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants