Repository navigation
transfer code from old feature branch - #171
Conversation
|
This PR contains a tidied up version of the updates in #169. Description copied from there: Updates to the CRT hit - TPC track matching algorithm that were described in docdb 22851 |
|
I think this requires #143 completed in order to appropriately test prior to merge. In the meantime, we should make sure it doesn't follow too far behind develop. @pgreen135 can we update this against develop this week, to be sure we don't get too far behind. Also, a test build may then be warranted? |
|
@wesketchum yes can do |
|
I think we may be getting closer to having the CRT issues fixed. @pgreen135 can we update this against develop? If not successful, we'll need to spend some time to resolve any issues... |
|
@wesketchum done, no conflicts. Let me know when this is ready to be merged |
|
and builds successfully too! |
|
I believe this is now ready to be merged as the CRT fixes are in place, shall I change this from being a draft or is there still additional work to be done? |
|
@pgreen135 I believe that is the case! When you can, please update this to a real PR and let's get it in! |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
|
This is failing the unit tests with the following error: |
|
On it ... |
|
There is an associated sbnobj branch: https://github.com/SBNSoftware/sbnobj/tree/feature/mstancar_CRTtimetag/sbnobj |
|
trigger build SBNSoftware/sbnobj#34 |
1 similar comment
|
trigger build SBNSoftware/sbnobj#34 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
The warnings in product sizes are expected due to the harsher cuts being placed on the CRT-TPC matching and additional association between the T0 and the CRT hit |
|
great, thanks @etyley from my side this looks ready to go -- does this want to be merged into the SBN2021C branch (to be included in the next patch) or just to develop? @wesketchum |
|
I would vote it gets merged into SBN2021C branch (and develop), thanks everyone! |
|
okay, I've updated these PRs (sbnobj too) to point towards the SBN2021C branches |
No description provided.