Skip to content

Add another globalTree bail out condition for the case where the list of labels is empty - #206

Merged
miquelnebot merged 3 commits into
release/SBN2021Cfrom
bugfix/multiple_globaltrees
Dec 1, 2021
Merged

miquelnebot merged 3 commits into
release/SBN2021Cfrom
bugfix/multiple_globaltrees

Conversation

@cjbacchus

Copy link
Copy Markdown
Contributor

This fixes the "multiple globalTrees in output" problem for job configurations that don't include any reweights. I think that problem is harmless, but aesthetically unappealing, so if this simple fix could sneak in somewhere that would be good.

miquelnebot and others added 3 commits November 22, 2021 06:26
sbncode SBN2021C
production release tag, using:
sbncode             v09_37_01

larsoft             v09_37_01
sbnobj              v09_12_08
sbnanaobj           v09_17_06
sbndata             v01_03

@brucehoward-physics brucehoward-physics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that I don't see globalTree in my data test file after this change.

@miquelnebot
miquelnebot changed the base branch from develop to release/SBN2021C December 1, 2021 12:12
@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot
miquelnebot merged commit a517bf3 into release/SBN2021C Dec 1, 2021
@cjbacchus
cjbacchus deleted the bugfix/multiple_globaltrees branch August 30, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants