Skip to content

Miscellaneous fixes for develop - #939

Open
mvicenzi wants to merge 13 commits into
developfrom
errare-humanum-est
Open

mvicenzi wants to merge 13 commits into
developfrom
errare-humanum-est

Conversation

@mvicenzi

@mvicenzi mvicenzi commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

This PR collects miscellaneous fixes for develop/v10_31_00_02.
Mostly configuration changes that got mixed in the porting/merging of various PRs.

  • Wire-Cell detsim: per-TPC YZ sim takes tuned gains, time offsets, lifetime and shaping from base config again; YZ maps read from fcl; shifted field responses restored; Run 4 gain map set on daq0..3.
  • Stage0: CRT data kept; on-beam PMT waveforms kept; new purity-monitor-only fcl.
  • Stage1: shower ApplyMCLifetimeCorrection renamed ApplyLifetimeCorrection (true MC, false data/overlay).
  • CAF: new SCE variation fcls; old blinding off.
  • Overlays: SimInfoMixer tag fixes.
  • Build: Generators links icarusalg::Utilities.

@mvicenzi mvicenzi self-assigned this Nov 12, 2026
@mvicenzi mvicenzi added the bug Something isn't working label Nov 12, 2026
@mvicenzi mvicenzi changed the title Miscellaneus fixes for develop Miscellaneous fixes for develop Nov 12, 2026
mvicenzi and others added 3 commits November 17, 2026 14:29
- YZ jsonnets: read YZMap file names from fcl (YZMapJson, YZScaleMapJson)
  again; the merge of PR 905 (147c112) had hardcoded the Run 1 maps.
- detsimmodules_wirecell_per_TPC_ICARUS.fcl: tuned gains (18.0839,
  12.2379, 13.8819 mV/fC) and time offsets (2.53, 2.41, 2.53 us) as in
  detsimmodules_wirecell_ICARUS.fcl; add YZ map and lifetime DB params
  (DBFileName/DBTag, needed by the overlay drifter). The yz_0..3 blocks
  now take these values, DL/DT and lifetime from the base block instead
  of stale literals.
- Run4 detsim fcls: set the Run 4 gain map on daq0..daq3, since the YZ
  sim no longer has a single daq module.
- detsimmodules_wirecell_ICARUS.fcl: base config back to the non-YZ
  refactored jsonnet, matching its outputers (as in v10_06_00_06p03).
…hat shifted responses are used so that simulation and reconstruction are aligned in time thereby granting a truth-matching to work.
…d assign them in the same way for each tpc.
@mvicenzi
mvicenzi marked this pull request as ready for review November 20, 2026 14:01
@mvicenzi
mvicenzi requested a review from acampani November 20, 2026 14:02
@jas1005

jas1005 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

trigger build larsoft@v10_31_00 LArSoft/lar*@LARSOFT_SUITE_v10_31_00 SBNSoftware/sbnalg@v10_31_00_02 SBNSoftware/sbnobj@v10_31_00_02 SBNSoftware/sbnanaobj@v10_31_00_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_31_00_02 SBNSoftware/icarusalg@v10_31_00_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e28:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e28:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants