Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of CVN code from PR #869 .
ICARUSCVN cleanup: use central larrecodnn TF graph/handler and remove local duplicates
Description
This PR reduces duplicated CVN/TensorFlow code in ICARUSCVN by switching to central implementations in LArSoft/larrecodnn, while keeping ICARUS-specific reconstruction/pixel-map/zlib logic unchanged.
What changed
Deleted:
icaruscode/ICARUSCVN/tf/tf_graph.cc
icaruscode/ICARUSCVN/tf/tf_graph.h
icaruscode/ICARUSCVN/tf/CMakeLists.txt
icaruscode/ICARUSCVN/modules/ICARUSTFNetHandler_tool.cc
icaruscode/ICARUSCVN/module_helpers/ICARUSITFNetHandler.h
Updated CMake to remove local ICARUSCVN_tf and local TF tool wiring.
ICARUSCVNEvaluator now uses:
larrecodnn/CVN/interfaces/ITFNetHandler.h
central tool type TFNetHandler
and calls:
Predict(const PixelMap&)
instead of local extended signatures.
Removed evaluator .gz path mode
Removed evaluator code path and helpers that loaded .gz pixel-map files from disk. Evaluator now runs only on event/slice-based ROOT inputs (the standard module path).
Removed personal/non-production artifacts
Deleted:
icaruscode/ICARUSCVN/fcls/getTrueInfo.py
ICARUS-specific logic intentionally kept
No physics/geometry refactor in:
ICARUSPixelMapProducer.*
ICARUSICVNMapper.*
ICARUSICVNZlibMaker.*
ICARUSCVNZlibMaker_module.cc
These remain local and detector-specific.
Configuration note (important)
Central TFNetHandler expects LibPath to be the name of an environment variable.
For ICARUS data products, this PR config uses:
LibPath: "ICARUS_DATA_DIR"
TFProtoBuf: "icarus_data/CVN/icarus_cvn_flavor.pb"
So the resolved model file is:
$ICARUS_DATA_DIR/icarus_data/CVN/icarus_cvn_flavor.pb
Validation checklist
Build succeeds
run_ICARUSCVNEvaluator.fcl runs on a small stage1 ROOT sample
Context
This is a maintenance-focused cleanup intended to reduce local code duplication after the original author’s departure, while preserving ICARUS-specific behavior.