Repository navigation
Conversation
|
Hi Jacob, thanks for reaching out about this PR. I originally opened this PR for some bug fixes to our standard FHiCLs when not including the YZ simulation in the processing chain. This enabled developments on the reconstruction side (producing test samples with the YZ simulation is just prohibitive from a resources standpoint), so in a sense the workflow was already validated. Indeed, those FHiCLs refer to the I think that #877 was meant to generalize this PR, so we'll have a chat with Mattia and check whether we can close this and open #877. We'll let you know! |
|
Hello! I agree with Riccardo's message. #877 was indeed intended to be a more "general" version of this, and more up to date with respect to the official releases (at least, tested with |
|
@rtriozzi and @mattiasotgia, I wanted to follow up on this. Is it okay to close this PR? #877 is only a draft PR at this time. |
|
Hi Jacob, Riccardo is no longer active.
I guess it is ok to close this PR, I will probably open an issue to remind me to open a similar PR (defining the FHiCLs for no-YZ simulation as well as 1D complete chain) once we are ok with the latest releases.
… On 17 Oct 2026, at 7:50 AM, Jacob Smith ***@***.***> wrote:
jas1005
left a comment
(SBNSoftware/icaruscode#865)
<#865 (comment)>
@rtriozzi <https://github.com/rtriozzi> and @mattiasotgia <https://github.com/mattiasotgia>,
I wanted to follow up on this. Is it okay to close this PR? #877 <#877> is only a draft PR at this time.
—
Reply to this email directly, view it on GitHub <#865?email_source=notifications&email_token=AFCOOF2ND7AONGD452ZCAL35UMCBTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRTGAZTMMZTGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6230363317>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFCOOF5GU64EOFBNIURPQ6T5UMCBTAVCNFSNUABFKJSXA33TNF2G64TZHMZDCMJRHA3TOMBUHNEXG43VMU5TGNRQGEYDONRZGY4KC5QC>.
You are receiving this because you were mentioned.
|
This PR fixes some labels in the detsim fcl without the YZ-simulation. The downstream reconstruction chain had to be updated accordingly. This fix would enable producing testing samples much more quickly, as running the YZ-simulation on the grid got very hard lately. Currently opening this PR with fcls from
v10_06_00_01p01for discussion: I can provide similar fixes fordevelop, eventually. Thanks!