You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PMT timing corrections should not be applied on simulation #464
The code in PR #440 applies a time correction to the reconstructed PMT hits read from a database according to the run their event belongs to.
In case of simulation, this correction should be disabled completely, the service interfacing to that database should not be used nor required.
Ideally, that service itself should be able also to return a neutral correction when dealing with Monte Carlo events.
It should be pointed out that the MC and data workflows are different, and currently Stage0 is written so that Monte Carlo jobs generate optical hits in ophit directly with the hit finding algorithm, while data jobs generate optical hits in ophituncorrected and then apply the correction creating ophit.
In my opinion this is also the best way to avoid unnecessary dependencies (the MC job does not need the database service to be configured).
Nevertheless it would be good to neuter the timing correction module to just copy MC hits.
#892 will resolve this issue. Timing corrections will be fully disabled in the legacy MC flow; while in the new MC-Overlays flow they will be used in both detsim and stage0 to properly simulate the timing delays and then correct for them after overlaying the data waveforms.
Activity
miquelnebot commentedon Nov 9, 2022
@PetrilloAtWork what's the status of this one?
PetrilloAtWork commentedon Nov 30, 2022
Still to-do.
PetrilloAtWork commentedon Dec 2, 2022
It should be pointed out that the MC and data workflows are different, and currently
Stage0is written so that Monte Carlo jobs generate optical hits inophitdirectly with the hit finding algorithm, while data jobs generate optical hits inophituncorrectedand then apply the correction creatingophit.In my opinion this is also the best way to avoid unnecessary dependencies (the MC job does not need the database service to be configured).
Nevertheless it would be good to neuter the timing correction module to just copy MC hits.
mvicenzi commentedon May 7, 2026
#892 will resolve this issue. Timing corrections will be fully disabled in the legacy MC flow; while in the new MC-Overlays flow they will be used in both
detsimandstage0to properly simulate the timing delays and then correct for them after overlaying the data waveforms.