Skip to content

PMT timing corrections should not be applied on simulation #464

Open

Description

@PetrilloAtWork

The code in PR #440 applies a time correction to the reconstructed PMT hits read from a database according to the run their event belongs to.
In case of simulation, this correction should be disabled completely, the service interfacing to that database should not be used nor required.
Ideally, that service itself should be able also to return a neutral correction when dealing with Monte Carlo events.

Activity

  1. miquelnebot commented on Nov 9, 2022

    @miquelnebot
    Contributor

    @PetrilloAtWork what's the status of this one?

  2. PetrilloAtWork commented on Nov 30, 2022

    @PetrilloAtWork
    MemberAuthor

    Still to-do.

  3. PetrilloAtWork commented on Dec 2, 2022

    @PetrilloAtWork
    MemberAuthor

    It should be pointed out that the MC and data workflows are different, and currently Stage0 is written so that Monte Carlo jobs generate optical hits in ophit directly with the hit finding algorithm, while data jobs generate optical hits in ophituncorrected and then apply the correction creating ophit.
    In my opinion this is also the best way to avoid unnecessary dependencies (the MC job does not need the database service to be configured).
    Nevertheless it would be good to neuter the timing correction module to just copy MC hits.

  4. linked a pull request that will close this issueOptical sim/reco and overlay updates #892on May 7, 2026
  5. mvicenzi commented on May 7, 2026

    @mvicenzi
    Member

    #892 will resolve this issue. Timing corrections will be fully disabled in the legacy MC flow; while in the new MC-Overlays flow they will be used in both detsim and stage0 to properly simulate the timing delays and then correct for them after overlaying the data waveforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions