Skip to content

Adding two missing possibilities for ValueListParameter - #292

Merged
phanak-sap merged 2 commits into
SAP:masterfrom
frij-aws:constants
Apr 26, 2025
Merged

phanak-sap merged 2 commits into
SAP:masterfrom
frij-aws:constants

Conversation

@frij-aws

@frij-aws frij-aws commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Adding two missing possibilities for ValueListParameter from from the SAP common vocabulary list

@phanak-sap

Copy link
Copy Markdown
Contributor

Hi frij-aws.

Thx for pull request. Straightforward and simple.

  1. I am quite surprised no test was actually need to be updated as well - clearly missing some automation here :)

  2. Am I correct that we have in pyodata already hardcoded things that are SAP specific in a model.py, that tries to be covering Odata specification and adding SAP-only things ideally to different, isolated module like vendors/SAP.py? :)

Both are just open question, I am willing to merge as is.

@frij-aws

frij-aws commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

To be honest I do not know what these constants are for or what they do, so I'm not 100% sure about the answers to your questions -- although I agree on (2) that it smells bad to have SAP-specific stuff in model.py. :)

@phanak-sap
phanak-sap merged commit 24d8135 into SAP:master Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants