[manuelseeger]

Deferred nav properties were instantiated as entity proxies. With this change only expanded nav properties are instantiated.

Fixes #262

[filak-sap]

Good job! Thank you for taking care of code you have changed! Really appreciated.

[phanak-sap]

Hi @filak-sap, should this line be changed as well? I was not having time yet to create reproducing tests, resp finding service returning data in such format - but struck me that this part also expects that entities are returned only under 'results' key in the JSON response.

Is that line still correct? With the context of this PR and original issue #258? Or am I missing something?

python-pyodata/pyodata/v2/service.py

Line 1543 in 0d5c9da

entities = entities['results']

[manuelseeger]

#258 was about expanded, inline collection of entities - which do not have a wrapping results object. Regular, top-level entity collections are supposed to be wrapped in a results object in v2.

get_entities_handler() from https://github.com/SAP/python-pyodata/blob/0d5c9dabfc7e5b99837eaf7fdccc592bc344d623/pyodata/v2/service.py#L1519C9-L1519C21
should be fine as-is.

[phanak-sap]

@manuelseeger thx for the check and confirming explanation, I see now, compared to the referenced spec from #238.