Repository navigation
Fix adding expanded entities to EntityProxy - #259
Merged
Merged
Conversation
EntityProxy expected expanded properties to be wrapped in a 'results' object, which isn't to V2 JSON spec. This fix removes this expectation. The original behavior is not removed, so if there happens to be an expanded property wrapped in a 'results' object, EntityProxy continues to work as before. Fixes SAP#258
|
|
Contributor
|
Simple, yet backward compatible fix with necessary changes of test suite. Perfect. Thanks @manuelseeger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityProxy expected expanded properties to be wrapped in a 'results' object, which isn't to V2 JSON spec. This fix removes this expectation. The original behavior is not removed, so if there happens to be an expanded property wrapped in a 'results' object, EntityProxy continues to work as before.
Fixes #258