Repository navigation
model: fix default Edm.DateTimeOffset value (#195) - #197
phanak-sap merged 2 commits into
Conversation
|
Well, since the Edm.DateTime default value is also causing problems, as you find out in issue #79, why not change both Edm.DateTime and Edm.DateTimeOffset to the January 1, 1753 A.D, noted in this comment |
|
note: not sure why, but build was not triggered for this PR |
|
Could you please rebase to the latest master (I don't like merge commits). |
phanak-sap
left a comment
phanak-sap
left a comment
There was a problem hiding this comment.
Marking that the defaults for both Edm.DateTimeOffset and Edm.DateTime should be January 1, 1753 A.D
22fbe4c to
4293d43
Compare
Default value was broken in several ways: - Month 0 does not exist - Day 0 does not exist - Year 0 can not be handled by Python datetime
This makes it easier, more likely, to spot dates fixed-up by pyodata. The new value aligns with Edm.DateTimeOffset.
4293d43 to
a264bac
Compare
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 92.66% 92.81% +0.14%
==========================================
Files 6 6
Lines 2768 2768
==========================================
+ Hits 2565 2569 +4
+ Misses 203 199 -4
Continue to review full report at Codecov.
|
|
Thanks for the fix. Good work. |
Default value was broken in several ways:
The new default value is copied from Edm.DateTime for consistency reasons. However, choosing something less common like 1.1.1 or 1.1.1970 might be more sensible?