Repository navigation
Nullable values - #100
Merged
Merged
Nullable values#100
Conversation
filak-sap
force-pushed
the
nullable_values
branch
2 times, most recently
from
April 29, 2020 11:26
c776c12 to
4f06094
Compare
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 92.41% 92.81% +0.40%
==========================================
Files 6 6
Lines 2439 2465 +26
==========================================
+ Hits 2254 2288 +34
+ Misses 185 177 -8
Continue to review full report at Codecov.
|
filak-sap
force-pushed
the
nullable_values
branch
2 times, most recently
from
April 29, 2020 21:59
445b94e to
cc8c71a
Compare
phanak-sap
reviewed
Apr 30, 2020
phanak-sap
reviewed
Apr 30, 2020
phanak-sap
reviewed
Apr 30, 2020
I came a cross this difference during testing of SAP#95 I decided to set tzinfo of JSON DateTimes to simplify my tests and it also make sense to me to have the values configured the same way.
Tests will appear in the next commit. I don't find it usefull to add the tests here.
Only a declared property knows if it accepts Null or not. I was playing with nullable Type but than I would have to have also nullable TypeTraits and there result would be a complete mess. Therefore I decided to move the responsibility to serialize/deserialize the declared property. The decision led to a simpler code which is a good sign. I could have used a better exception type but we currently evaluating the best exception strategies, so I used a generic type. Part of the issue SAP#95
filak-sap
force-pushed
the
nullable_values
branch
from
April 30, 2020 09:39
cc8c71a to
ce0b6cf
Compare
phanak-sap
approved these changes
Apr 30, 2020
phanak-sap
left a comment
phanak-sap
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, comments resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.