Update to the latest ASDL - #93
Conversation
| stmt = FunctionDef(identifier name, arguments args, | ||
| stmt* body, expr* decorator_list, expr? returns, | ||
| string? type_comment) | ||
| string? type_comment, type_param* type_params) |
There was a problem hiding this comment.
Unrelated to this PR: @youknowone do you know if RustPython parses out type_comments or if we could remove this (unused) field?
There was a problem hiding this comment.
We don't parse it now. So removing it is okay right now.
To let RustPython keep the field for AST, changing to the type to empty tuple () will be better than entirely removing it.
Since type_comment is a part of Python3 spec, I thought it is expected to be implemented. CPython parser has an option flag to parse it or not.
|
@youknowone this should be ready now if you could approve the workflow again |
|
@youknowone this looks good to me. I'll go ahead and merge it by tomorrow evening (around now). Let me know if you object and I'll then defer merging too you. |
3 participants
Uses to latest ASDL to generated code for handling of new generic type syntax. Note this does not otherwise attempt to add handling for the new syntax, the new fields should always be empty.
Required for #82