Skip to content

4.x: Isolate FutureSubscriber race tests - #8393

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/future-subscriber-isolated
Nov 17, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/future-subscriber-isolated

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Related #8075.

Move these TestHelper.race tests from FutureSubscriberTest into FutureSubscriberIsolatedTest, following the requested naming pattern:

  • cancelRace
  • onErrorCancelRace
  • onCompleteCancelRace

All method bodies, loop counts, operations, assertions, and @SuppressUndeliverable annotations are retained. This batch contains 2 test-file changes (+76/-49) and no production-code changes.

Verification

Using Zulu 26.0.2.1 and Gradle 9.9.0:

  • All 3 moved tests passed.
  • checkstyleTest passed.
  • This is a draft while the upstream CI runs. I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. Every moved method, annotation, and the final diff were checked against the upstream originals.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.764 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/subscribers/FutureSubscriberIsolatedTest.java: 4.836
src/test/java/io/reactivex/rxjava4/internal/subscribers/FutureSubscriberTest.java: 4.691

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@jimi-21
jimi-21 marked this pull request as ready for review November 17, 2026 09:41
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (77d4ee3) to head (6ff02ce).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8393      +/-   ##
============================================
- Coverage     98.66%   98.59%   -0.07%     
+ Complexity     7172     7167       -5     
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
- Hits          50290    50256      -34     
- Misses          466      483      +17     
- Partials        216      233      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd
akarnokd merged commit 884e27d into ReactiveX:4.x Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants