Skip to content

4.x: Increase virtual TCK timeout to 50 ms - #8388

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/virtual-tck-timeout
Nov 17, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/virtual-tck-timeout

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Closes #8378.

Following the maintainer's suggestion, override the default 25 ms timeout with 50 ms in the two TCK classes that failed intermittently during local full TestNG runs:

  • FlowableVirtualTransformVirtual2TckTest
  • FlowableVirtualCreateVirtualTckTest

This uses the existing BaseTck(long timeout) constructor and leaves the global default unchanged. Only 2 test files are changed (+8/-0); no production code is modified.

Verification

Using Zulu 26.0.2.1 and Gradle 9.9.0:

  • Targeted testNG for both affected classes passed.
  • Full testNG passed without the previous 25 ms timeout failures.
  • checkstyleTest passed.
  • This is a draft while the upstream CI runs. I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. The approach follows akarnokd's comment in #8378.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.814 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/virtual/tck/FlowableVirtualCreateVirtualTckTest.java: 4.844
src/test/java/io/reactivex/rxjava4/internal/virtual/tck/FlowableVirtualTransformVirtual2TckTest.java: 4.784

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd akarnokd added this to the 4.0 milestone Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (42b28e7) to head (8c81a5c).
⚠️ Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8388      +/-   ##
============================================
- Coverage     98.62%   98.61%   -0.01%     
  Complexity     7169     7169              
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
- Hits          50272    50267       -5     
- Misses          476      478       +2     
- Partials        224      227       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimi-21
jimi-21 marked this pull request as ready for review November 17, 2026 08:41
@akarnokd
akarnokd merged commit a4dfc30 into ReactiveX:4.x Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] BaseTck hard-coded 25 ms timeout is flaky on slower machines

2 participants