Repository navigation
4.x: Increase virtual TCK timeout to 50 ms - #8388
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.814 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
akarnokd
approved these changes
Nov 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8388 +/- ##
============================================
- Coverage 98.62% 98.61% -0.01%
Complexity 7169 7169
============================================
Files 826 826
Lines 50972 50972
Branches 6944 6944
============================================
- Hits 50272 50267 -5
- Misses 476 478 +2
- Partials 224 227 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jimi-21
marked this pull request as ready for review
November 17, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8378.
Following the maintainer's suggestion, override the default 25 ms timeout with 50 ms in the two TCK classes that failed intermittently during local full TestNG runs:
FlowableVirtualTransformVirtual2TckTestFlowableVirtualCreateVirtualTckTestThis uses the existing
BaseTck(long timeout)constructor and leaves the global default unchanged. Only 2 test files are changed (+8/-0); no production code is modified.Verification
Using Zulu 26.0.2.1 and Gradle 9.9.0:
testNGfor both affected classes passed.testNGpassed without the previous 25 ms timeout failures.checkstyleTestpassed.AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. The approach follows akarnokd's comment in #8378.