Skip to content

4.x: Isolate CompositeDisposable race tests - #8384

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/composite-disposable-isolated
Nov 17, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/composite-disposable-isolated

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Related #8075.

Move all 12 TestHelper.race tests from CompositeDisposableTest into CompositeDisposableIsolatedTest, following the requested naming pattern:

  • disposeRace, addRace, addAllRace, removeRace, deleteRace, clearRace
  • addDisposeRace, addAllDisposeRace, removeDisposeRace, deleteDisposeRace, clearDisposeRace, sizeDisposeRace

All method bodies, loop counts, operations, and assertions are retained verbatim. This batch contains 2 test-file changes (+196/-172) and no production-code changes.

Verification

Using Zulu 26.0.2.1 and Gradle 9.9.0:

  • All 12 moved tests passed.
  • checkstyleTest passed.
  • This is a draft while the upstream CI runs. I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. Every moved method and the final diff were checked against the upstream originals.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.55 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableIsolatedTest.java: 4.619
src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableTest.java: 4.481

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (5cc9774) to head (286ee8f).
⚠️ Report is 5 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8384      +/-   ##
============================================
+ Coverage     98.61%   98.63%   +0.01%     
- Complexity     7167     7173       +6     
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
+ Hits          50265    50274       +9     
+ Misses          480      470      -10     
- Partials        227      228       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd added the AI label Nov 17, 2026
@akarnokd akarnokd added this to the 4.0 milestone Nov 17, 2026
@jimi-21
jimi-21 marked this pull request as ready for review November 17, 2026 07:54
@akarnokd
akarnokd merged commit 2421c2e into ReactiveX:4.x Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants