Skip to content

4.x: Isolate Disposable race tests - #8383

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/disposable-isolated
Nov 17, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/disposable-isolated

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Related #8075.

Move these TestHelper.race tests into @Isolated classes, following the requested naming pattern:

  • DisposableTest.disposeRace -> DisposableIsolatedTest
  • CancellableDisposableTest.disposeRace -> CancellableDisposableIsolatedTest

Both method bodies, loop counts, and assertions are retained verbatim. This batch contains 4 test-file changes (+82/-29) and no production-code changes.

Verification

Using Zulu 26.0.2.1 and Gradle 9.9.0:

  • Both moved tests passed.
  • checkstyleTest passed.
  • This is a draft while the upstream CI runs. I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. The moved methods and diff were checked against the upstream originals.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.824 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/disposables/DisposableIsolatedTest.java: 4.959
src/test/java/io/reactivex/rxjava4/disposables/DisposableTest.java: 4.614
src/test/java/io/reactivex/rxjava4/internal/disposables/CancellableDisposableIsolatedTest.java: 4.919
src/test/java/io/reactivex/rxjava4/internal/disposables/CancellableDisposableTest.java: 4.807

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (0c7b453) to head (40efe68).
⚠️ Report is 4 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8383      +/-   ##
============================================
- Coverage     98.61%   98.58%   -0.03%     
  Complexity     7168     7168              
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
- Hits          50264    50251      -13     
- Misses          477      488      +11     
- Partials        231      233       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimi-21
jimi-21 marked this pull request as ready for review November 17, 2026 07:41
@akarnokd akarnokd added this to the 4.0 milestone Nov 17, 2026
@akarnokd
akarnokd merged commit 2c3a91f into ReactiveX:4.x Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants