Skip to content

4.x: Make Completable repeatNormal deterministic - #8377

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/completable-repeat-normal-deterministic
Nov 16, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
jimi-21:test/completable-repeat-normal-deterministic

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #8372.

Make CompletableIsolatedTest.repeatNormal deterministic by disposing on the sixth invocation instead of at a wall-clock deadline.

The test still exercises repeat() and disposal and retains the 200 ms invocation delay, but no longer depends on scheduler timing producing exactly six calls.

This is a test-only change: 1 file, +5/-4.

Verification

Using Zulu 26.0.2.1 and Gradle 9.9.0:

  • repeatNormal passed 3 consecutive times, consistently stopping at 6 calls.
  • checkstyleTest passed.
  • This is a draft while the upstream CI runs. I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to reproduce the timing issue, prepare and validate the fix, and draft this PR description.

@akarnokd akarnokd added this to the 4.0 milestone Nov 16, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.717 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java: 4.717

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@jimi-21
jimi-21 marked this pull request as ready for review November 16, 2026 16:20
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (bd3d7f8) to head (6c3b597).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8377      +/-   ##
============================================
- Coverage     98.63%   98.57%   -0.07%     
+ Complexity     7169     7165       -4     
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
- Hits          50277    50244      -33     
- Misses          471      485      +14     
- Partials        224      243      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd
akarnokd merged commit 0c7b453 into ReactiveX:4.x Nov 16, 2026
8 checks passed
@akarnokd akarnokd added the AI label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] CompletableIsolatedTest.repeatNormal has a wall-clock-dependent call-count assertion

2 participants