Repository navigation
4.x: Make Completable repeatNormal deterministic - #8377
Merged
akarnokd merged 1 commit intoNov 16, 2026
Merged
Conversation
akarnokd
approved these changes
Nov 16, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.717 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
jimi-21
marked this pull request as ready for review
November 16, 2026 16:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8377 +/- ##
============================================
- Coverage 98.63% 98.57% -0.07%
+ Complexity 7169 7165 -4
============================================
Files 826 826
Lines 50972 50972
Branches 6944 6944
============================================
- Hits 50277 50244 -33
- Misses 471 485 +14
- Partials 224 243 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8372.
Make
CompletableIsolatedTest.repeatNormaldeterministic by disposing on the sixth invocation instead of at a wall-clock deadline.The test still exercises
repeat()and disposal and retains the 200 ms invocation delay, but no longer depends on scheduler timing producing exactly six calls.This is a test-only change: 1 file, +5/-4.
Verification
Using Zulu 26.0.2.1 and Gradle 9.9.0:
repeatNormalpassed 3 consecutive times, consistently stopping at 6 calls.checkstyleTestpassed.AI disclosure: Kimi Code was used to reproduce the timing issue, prepare and validate the fix, and draft this PR description.