Repository navigation
4.x: Isolate Maybe using race tests - #8371
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.731 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
jimi-21
marked this pull request as ready for review
November 16, 2026 14:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8371 +/- ##
============================================
+ Coverage 98.61% 98.63% +0.02%
+ Complexity 7169 7167 -2
============================================
Files 826 826
Lines 50972 50972
Branches 6944 6944
============================================
+ Hits 50265 50276 +11
+ Misses 477 468 -9
+ Partials 230 228 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8075.
Move these race tests from
MaybeUsingTestintoMaybeUsingIsolatedTest, following the naming requested in the issue:successDisposeRaceerrorDisposeRace(retaining@SuppressUndeliverable)emptyDisposeRaceAll three method bodies, loop counts, assertions, and annotations are retained verbatim. This batch contains 2 test-file changes (+87/-60) and no production-code changes.
Verification
Using Zulu 26.0.2.1 and Gradle 9.9.0:
announcecase was skipped.checkstyleTestpassed.AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. The moved methods and diff were checked against the upstream originals.