Skip to content

4.x: Isolate Single using and amb race tests - #8361

Merged
akarnokd merged 4 commits into
ReactiveX:4.xfrom
jimi-21:test/single-using-amb-isolated
Nov 16, 2026
Merged

akarnokd merged 4 commits into
ReactiveX:4.xfrom
jimi-21:test/single-using-amb-isolated

Conversation

@jimi-21

@jimi-21 jimi-21 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Related #8075.

Move these race tests into corresponding @Isolated classes, following the naming requested in the issue:

  • SingleUsingTest: successDisposeRace, errorDisposeRace
  • SingleAmbTest: nullSourceSuccessRace, multipleErrorRace, successErrorRace

All five method bodies, loop counts, assertions, and plugin cleanup are retained verbatim. This batch contains 4 test-file changes (+201/-132) and no production-code changes.

Verification

Using Temurin/Zulu 26.0.2.1 and Gradle 9.9.0:

  • The 5 moved tests passed; only the inherited announce cases were skipped.
  • The full 14,296-test JUnit suite passed in a single-fork run.
  • Multiple full-build attempts on the local Windows machine also hit varying pre-existing concurrency/TCK timing failures outside these Single tests. The affected classes pass when rerun independently. I am opening this as a draft so the upstream CI can provide a clean verification run; I will not mark it ready while related checks are failing.

AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. The moved methods and diff were checked against the upstream originals.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.729 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleAmbIsolatedTest.java: 4.622
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleAmbTest.java: 4.740
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingIsolatedTest.java: 4.893
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingTest.java: 4.662

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (a4a5393) to head (70b38ba).
⚠️ Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8361      +/-   ##
============================================
+ Coverage     98.60%   98.63%   +0.03%     
- Complexity     7168     7171       +3     
============================================
  Files           826      826              
  Lines         50972    50972              
  Branches       6944     6944              
============================================
+ Hits          50261    50278      +17     
+ Misses          478      475       -3     
+ Partials        233      219      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd added this to the 4.0 milestone Nov 16, 2026
@jimi-21
jimi-21 marked this pull request as ready for review November 16, 2026 12:16
@akarnokd
akarnokd merged commit 6d5183a into ReactiveX:4.x Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants