Repository navigation
Conversation
akarnokd
approved these changes
Nov 16, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.622 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8354 +/- ##
=========================================
Coverage 98.62% 98.62%
+ Complexity 7170 7169 -1
=========================================
Files 826 826
Lines 50972 50972
Branches 6944 6944
=========================================
Hits 50269 50269
+ Misses 479 476 -3
- Partials 224 227 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
raceToStream()cancels both subscribers after they attach, while its defaultsubscribeoverload owns an executor that the test cannot join.StreamableBaseTest.afterTest()eagerly runs the Cleaner callbacks recorded forCompletionStageDisposable. A subscribe task still completing when that cleanup runs can therefore report the undeliveredCompletionStageDisposable was not awaited or ignored explicitlyerror from #8340.Change
Use a test-owned virtual-thread executor for both subscribers. Cancel both subscribers in
finally, then close the executor before the test method returns so its asynchronous subscribe tasks finish beforeafterTest()inspects tracked stages. Keep the existing attachment and cancellation assertions.Fixes #8340
Validation
.\gradlew.bat cleanTest test --tests 'io.reactivex.rxjava4.internal.operators.streamable.DispatchStreamProcessorTest.raceToStream' --no-daemon- BUILD SUCCESS on Windows with Temurin JDK 26.0.2.1..\gradlew.bat cleanTest test --tests 'io.reactivex.rxjava4.internal.operators.streamable.DispatchStreamProcessorTest' --no-daemon- BUILD SUCCESS on Windows with Temurin JDK 26.0.2.1.git diff --check- passed.AI-assisted: this contribution was prepared with AI assistance and reviewed against the repository code and tests.