Skip to content

3.x: unnecessary call to upstream .cancel() in FlowablePublishMulticast operator #6989

Closed

Description

@sobersanta

I think I should add it as a separate issue.

In a casual completion chain from the upstream, when it is calling onComplete/onError, FlowablePublishMulticast calls SubscriptionHelper.cancel(upstream); in the dispose() method (line 196).
I believe that upstream cancellation should be done only from .cancel() method not from .onComplete or .onError as it causes issues in some scenarios including extra groups creation in the groupBy operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions