You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
3.x: unnecessary call to upstream .cancel() in FlowablePublishMulticast operator #6989
In a casual completion chain from the upstream, when it is calling onComplete/onError, FlowablePublishMulticast calls SubscriptionHelper.cancel(upstream); in the dispose() method (line 196).
I believe that upstream cancellation should be done only from .cancel() method not from .onComplete or .onError as it causes issues in some scenarios including extra groups creation in the groupBy operator.
Activity