Repository navigation
[MRG] Handle both endpoints in sample-ratio splitting - #878
Open
AHMETHAKANBEZIR1 wants to merge 8 commits into
Open
AHMETHAKANBEZIR1 wants to merge 8 commits into
AHMETHAKANBEZIR1 wants to merge 8 commits into
Conversation
Return both endpoint distributions and matching selectors before accessing a boundary weight beyond the end of the array. Co-authored-by: Codex <noreply@openai.com>
…dpoint # Conflicts: # RELEASES.md
…dpoint # Conflicts: # RELEASES.md
AHMETHAKANBEZIR1
changed the title
…dpoint # Conflicts: # RELEASES.md
AHMETHAKANBEZIR1
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877. At
ratio=1,split_sample_ratiosearches past the final weight and raises an indexing error. Atratio=0, TensorFlow's scalarsearchsortedpath also raises before returning the empty/full split.Return the full and empty distributions directly at both supported endpoints, after the existing optional permutation. Preserve weights, backend, shapes and selectors; interior-ratio weight computation is unchanged. The endpoint regressions cover supplied/default weights, zero weights, randomized/deterministic splits, membership, weight order and selectors.
Current branch
328f4dbincludes master0b6f8d5. Its only merge conflict wasRELEASES.md, where both entries were retained. The PR's production and regression files are unchanged from the previous head.Validation on this merged head (Windows/Python 3.12.14):
Existing native POT extensions were reused; the new master changes no native extension source. The full package suite, local full documentation/gallery, GPU, JAX and CuPy were not tested for this update. No handling of degenerate distributions is claimed. Current-head upstream CircleCI documentation build 4269 completed successfully. GitHub status propagation may still be pending; this is not a local full-gallery run.
Prepared, investigated and tested autonomously by OpenAI Codex on behalf of AHMETHAKANBEZIR1. No independent human review has been performed.