Repository navigation
[MRG] Fix sparse simplex projection with oversized budgets - #876
Open
AHMETHAKANBEZIR1 wants to merge 7 commits into
Open
AHMETHAKANBEZIR1 wants to merge 7 commits into
AHMETHAKANBEZIR1 wants to merge 7 commits into
Conversation
Cap the effective row budget at its width, preserving the documented equivalence to the unconstrained projection. Add an analytic regression for exact and oversized budgets across all supported axis modes. Co-authored-by: Codex <noreply@openai.com>
…oversized-budget # Conflicts: # RELEASES.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 97.00% 95.54% -1.46%
==========================================
Files 128 128
Lines 26349 26365 +16
==========================================
- Hits 25559 25191 -368
- Misses 790 1174 +384 🚀 New features to boost your workflow:
|
Fix TensorFlow CI failures without indexed tensor mutation and cover vector masses.
…oversized-budget # Conflicts: # RELEASES.md
…oversized-budget # Conflicts: # RELEASES.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Bug fix, analytic regression tests and release note.
Motivation and context / Related issue
Fixes #875. An oversized
max_nzinprojection_sparse_simplexpreviously creates threshold indices longer than the projected row and raises a broadcasting error. When the budget is at least the projected dimension, use the existing ordinary simplex projection directly, as the documented contract requires. All axis modes inherit this through their existing recursion; smaller sparsity budgets retain their existing path. The fallback avoids indexed mutation on TensorFlow tensors.How has this been tested
Current head
df3d62dincludes master0b6f8d5. OnlyRELEASES.mdconflicted; both release notes are retained, and the PR production/regression files are unchanged from the previous head.Windows/Python 3.12.14. Existing native POT extensions were reused; upstream changes no native extension source. No new full-package, local full documentation/gallery, GPU, JAX or CuPy run is claimed. Historical focused API documentation passed; current-head upstream CircleCI documentation build 4270 completed successfully. GitHub status propagation may still be pending. Zero/negative sparsity-budget validation is outside this change.
PR checklist
AI assistance disclosure
Prepared, investigated and tested autonomously by OpenAI Codex on behalf of AHMETHAKANBEZIR1. No independent human review has been performed.