Skip to content

Rename master to main #717

Closed
Closed

Description

@rijobro

In line with other other projects including MONAI Core, I feel we should rename our master branch as main.

@wyli Although renaming the branch is easy, I'm worried about breaking cron jobs etc. What do you think?

Activity

  1. rijobro commented on May 19, 2022

    @rijobro
    ContributorAuthor

    Using egrep all of our Colab links would have to be changed, e.g.:

    "[![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/Project-MONAI/tutorials/blob/master/2d_classification/mednist_tutorial.ipynb)"

    to

    "[![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/Project-MONAI/tutorials/blob/main/2d_classification/mednist_tutorial.ipynb)"

  2. wyli commented on May 19, 2022

    @wyli
    Contributor

    thanks for the reminder, I think we should do this, I'll rename it now, please help fix any issues as well... cc @Project-MONAI/core-reviewers

  3. wyli commented on May 19, 2022

    @wyli
    Contributor

    Screenshot 2022-05-19 at 10 57 18

  4. wyli commented on May 19, 2022

    @wyli
    Contributor

    Using egrep all of our Colab links would have to be changed, e.g.:

    "[![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/Project-MONAI/tutorials/blob/master/2d_classification/mednist_tutorial.ipynb)"

    to

    "[![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/Project-MONAI/tutorials/blob/main/2d_classification/mednist_tutorial.ipynb)"

    looks like the previous URL is redirected to the renamed one and it's not an issue in this case

  5. rijobro commented on May 19, 2022

    @rijobro
    ContributorAuthor

    Great, we'll still need to update the cron jobs in the MONAI repository though, right?

    I created a PR to rename the URLs, do you think we should merge or close that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions