Skip to content

workaround 5882 reenable weekly preview release - #5887

Merged
wyli merged 5 commits into
devfrom
workaround-5882
Jan 23, 2023
Merged

wyli merged 5 commits into
devfrom
workaround-5882

Conversation

@wyli

@wyli wyli commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

part of #5882

Description

a workaround to not installing MetricsReloaded when packaging.
once pip install MetricsReloaded is made available we can undo the workaround.

workflow tested https://github.com/Project-MONAI/MONAI/actions/runs/3984778767/jobs/6831377542

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 4 commits January 23, 2023 08:45
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli requested review from ericspod and rijobro January 23, 2023 09:14
@wyli
wyli marked this pull request as ready for review January 23, 2023 09:14
@wyli
wyli requested a review from Warvito January 23, 2023 09:17
@wyli

wyli commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli
wyli enabled auto-merge (squash) January 23, 2023 10:13
@wyli
wyli merged commit 86a06f3 into dev Jan 23, 2023
@wyli
wyli deleted the workaround-5882 branch January 23, 2023 11:24
@ericspod ericspod mentioned this pull request Sep 1, 2026
1 of 7 tasks
ericspod added a commit that referenced this pull request Sep 4, 2026
### Description

This fixes an issue with git dependencies in the requirements for MONAI.
This was sorted earlier in #5887 but I missed this reference when
retiring setup.cfg. This also adds a step to publish to the Test PyPI
server but this is commented out for now until we have a working key.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants