feat(FOUR-30668): add API_FAST_TASK fast path for V1.1 task show by gproly · Pull Request #9097 · ProcessMaker/processmaker

gproly · 2026-10-09T21:06:29Z

Introduce showFast on GET api/1.1/tasks/{id} when API_FAST_TASK is enabled, keeping the same endpoint and response shape while reducing duplicate work on large request payloads.

Strip data from the include list so requestData is not built twice
Load task via Eloquent and process request metadata via raw SQL without the data column; hydrate relations with selective columns
Add TaskResource::fromTokenWithIncludes() to avoid preprocessInclude re-query
Resolve request data from DB when processRequest has no data attribute (showFast path and Nayra empty datastore)
Guard includeBpmnTagName when BPMN definition is missing
Add TaskShowFastResponseTimeTest (parity + median timing vs legacy includes)

Config: API_FAST_TASK=false by default in config/app.php
Timing: TASK_SHOW_FAST_MAX_RATIO (default 0.53) for the benchmark test

https://processmaker.atlassian.net/browse/FOUR-30668

Run:
./vendor/bin/phpunit tests/Feature/Api/V1_1/TaskShowFastResponseTimeTest.php

Tests:

Same request_data as legacy (fast has no data key)
Median of 3 runs: legacy (API_FAST_TASK=false) vs fast (true)

Threshold env:
TASK_SHOW_FAST_MAX_RATIO=0.53 default (~47% faster)
TASK_SHOW_FAST_MAX_RATIO=0.40 ~60% faster
TASK_SHOW_FAST_MAX_RATIO=0.30 ~70% faster

Rule: fast_median <= legacy_median * ratio

Improvement % ≈ (1 - fast/legacy) * 100 (same machine/DB each time)

Captura de pantalla 2026-10-09 a la(s) 5 10 39 p  m

ci:deploy

Introduce showFast on GET api/1.1/tasks/{id} when API_FAST_TASK is enabled, keeping the same endpoint and response shape while reducing duplicate work on large request payloads. - Strip `data` from the include list so `requestData` is not built twice - Load task via Eloquent and process request metadata via raw SQL without the `data` column; hydrate relations with selective columns - Add TaskResource::fromTokenWithIncludes() to avoid preprocessInclude re-query - Resolve request data from DB when processRequest has no `data` attribute (showFast path and Nayra empty datastore) - Guard includeBpmnTagName when BPMN definition is missing - Add TaskShowFastResponseTimeTest (parity + median timing vs legacy includes) Config: API_FAST_TASK=false by default in config/app.php Timing: TASK_SHOW_FAST_MAX_RATIO (default 0.53) for the benchmark test https://processmaker.atlassian.net/browse/FOUR-30668

cursor · 2026-10-09T21:06:40Z

PR Summary

Medium Risk
Changes a heavily used task API read path and how large process_requests.data is loaded, though behavior is gated by API_FAST_TASK (default false) and tests cover parity.

Overview
Adds an opt-in API_FAST_TASK fast path for GET api/1.1/tasks/{id} (default off). When enabled, show delegates to showFast, which strips data from the include query so requestData is not built twice, loads the task through TaskV11ShowFastRepository (lean process_requests row without the heavy data column, selective relation columns), and only hydrates request data when requestData is requested.

TaskResource::fromTokenWithIncludes() builds the response from an already-loaded token and skips re-fetching relations that are already eager-loaded. includeBpmnTagName now returns null when BPMN definition is missing instead of erroring.

Feature tests assert request_data parity with the legacy path, that include=data does not add a top-level data key on the fast path, and median response time improvement vs legacy under TASK_SHOW_FAST_MAX_RATIO (default 0.58).

^{Reviewed by Cursor Bugbot for commit d1b4ecb. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Stale Bugbot comment from a previous run.

vladyrichter · 2026-10-10T00:41:33Z

QA server K8S was successfully deployed https://tenant-1.ci-023a748934.engk8s.processmaker.net

…rtions https://processmaker.atlassian.net/browse/FOUR-30668

vladyrichter · 2026-10-13T16:49:30Z

QA server K8S was successfully deployed https://tenant-1.ci-023a748934.engk8s.processmaker.net

- Load process_requests.data in TaskV11ShowFastRepository when showFast includes requestData, instead of extending DataManager. - Restore DataManager to develop behavior; drop resolveRequestDataFromToken. - Fix empty include after stripping data (remove query param, trim parts). - Guard includeBpmnTagName when BPMN definition is missing on fast path. - Add test for include=data-only on API_FAST_TASK; remove DataManager hydration unit test superseded by fast-path parity. https://processmaker.atlassian.net/browse/FOUR-30668

Re-add tests/Feature/Api/V1_1/ProcessVariableControllerTest.php from develop after it was removed by mistake. Keeps FOUR-30668 aligned with develop for unrelated V1.1 process-variables coverage. https://processmaker.atlassian.net/browse/FOUR-30668

Restore tests/Feature/DataManagerTest.php from develop to drop an unrelated import-only diff. Fast-path request data coverage remains in TaskShowFastResponseTimeTest. https://processmaker.atlassian.net/browse/FOUR-30668

decisions-sonarqube · 2026-10-13T19:52:17Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit d1b4ecb. Configure here.}

cursor · 2026-10-13T19:59:11Z

+        if ($processRequest->user_id) {
+            $requestor = User::query()->select(self::REQUESTOR_COLUMNS)->find($processRequest->user_id);
+            $processRequest->setRelation('user', $requestor);
+        }


Requestor include loses user fields

Medium Severity

The fast path loads the requestor with only id, firstname, lastname, and email, then fromTokenWithIncludes skips further loading because processRequest.user is already set. Legacy show never applies that slim select: ProcessRequestToken has no requestor relation, so includeRequestor lazy-loads the full processRequest.user. With API_FAST_TASK enabled, requestor drops fields clients already rely on, such as username, avatar, status, and title.

Additional Locations (1)

ProcessMaker/Http/Resources/V1_1/TaskResource.php#L234-L238

^{Reviewed by Cursor Bugbot for commit d1b4ecb. Configure here.}

gproly requested review from caleeli and pmPaulis October 9, 2026 21:06

cursor Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread ProcessMaker/Http/Resources/V1_1/TaskResource.php

Comment thread ProcessMaker/Managers/DataManager.php Outdated

test(FOUR-30668): stabilize V1_1 PHPUnit timing and saved-search asse…

a24306a

…rtions https://processmaker.atlassian.net/browse/FOUR-30668

gproly added 4 commits October 13, 2026 14:15

chore(FOUR-30668): align DataManagerTest with develop

89245de

Restore tests/Feature/DataManagerTest.php from develop to drop an unrelated import-only diff. Fast-path request data coverage remains in TaskShowFastResponseTimeTest. https://processmaker.atlassian.net/browse/FOUR-30668

Merge branch 'develop' into feature/FOUR-30668

d1b4ecb

cursor Bot reviewed Oct 13, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(FOUR-30668): add API_FAST_TASK fast path for V1.1 task show - #9097

feat(FOUR-30668): add API_FAST_TASK fast path for V1.1 task show#9097
gproly wants to merge 6 commits into
developfrom
feature/FOUR-30668

gproly commented Oct 9, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

vladyrichter commented Oct 10, 2026

Uh oh!

vladyrichter commented Oct 13, 2026

Uh oh!

decisions-sonarqube Bot commented Oct 13, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Oct 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gproly commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vladyrichter commented Oct 10, 2026

Uh oh!

vladyrichter commented Oct 13, 2026

Uh oh!

decisions-sonarqube Bot commented Oct 13, 2026

Quality Gate passed

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Oct 13, 2026

Choose a reason for hiding this comment

Requestor include loses user fields

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gproly commented Oct 9, 2026 •

edited

Loading

cursor Bot commented Oct 9, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading