Skip to content

An in-range update of request-promise is breaking the build 🚨 #556

Closed

Description

@greenkeeper

The dependency request-promise was updated from 4.2.2 to 4.2.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

request-promise is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ✅ continuous-integration/travis-ci/push: The Travis CI build passed (Details).
  • ❌ ci/circleci: coverage: Your tests failed on CircleCI (Details).

Commits

The new version differs by 17 commits.

  • d831905 Version 4.2.3 (now really)
  • 37e8773 fix: updated indirect lodash dependency to fix security vulnerability
  • 229225e Version 4.2.3
  • 4f27097 chore: fix ci build for node v8+
  • c535eb6 Merge pull request #299 from aomdoa/fixToughCookieDep
  • 488947b Merge branch 'master' into fixToughCookieDep
  • 131abd7 fix: breaking change in tough-cookie v3
  • b454ddc chore: added node 8 and 10 to ci build
  • 6d11ddc fix: typo
  • 3a136ea Merge pull request #303 from lexjacobs/patch-1
  • 5e32191 docs: mention of wrapped request errors
  • 2ac4f3e Update rp.js
  • 1457338 Workaround on the cookie processing test.
  • 062d5f8 Limit the tough-cookie to 2.5 as 3.x removes node 0.10 support
  • 18c838a docs: cheat sheet for POST like HTML forms do

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Activity

  1. greenkeeper commented on Feb 15, 2019

    @greenkeeper
    ContributorAuthor

    After pinning to 4.2.2 your tests are passing again. Downgrade this dependency 📌.

  2. greenkeeper commented on Feb 15, 2019

    @greenkeeper
    ContributorAuthor

    Your tests for group default are passing again with this update. Explicitly upgrade default to this version 🚀

    Commits

    The new version differs by 3 commits.

    See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions