Skip to content

Module Development Task: Volume Restriction (Maximum Volume Transfer) #267

Closed

Description

@CPSTL

Module Development Task

Volume Restriction (Maximum Volume Transfer)

Module Type Bounty Completion deadline
Transfer Manager Approx. 10, 000 POLY 21 days to complete once task is confirmed by external developer(s).

Short Summary:

For this module, ‘Maximum Volume Transfer’ we want to implement it in a way that you can only transfer a limited number of the total number of tokens within a certain time period.

Any token-holder can only transfer up to a maximum of 500,000 tokens in a 90 day period, regardless of the other restrictions (0.5% of the 100,000,000 tokens issued by the company). This applies to all token-holders and not just affiliated parties.

Note: This can be implemented as TM module with current architecture.

Bounty Requirements

  1. Module specs are fulfilled
  2. Module is implemented using appropriate module interface
  3. Module is tested with >95% branch coverage
  4. Module is delivered before deadline
  5. Module does not present any bugs.
  6. 21 days to complete module from developers initial start date.

IMPORTANT: Please work from the development-1.5.0 branch instead of master.
Implementation Suggestion

Module Details Spec (Wireframe)

Wireframe Link: https://www.lucidchart.com/invitations/accept/75bdef55-cd39-48d9-bc1c-ac1d2fc76a39

Activity

  1. gitcoinbot commented on Sep 21, 2018

    @gitcoinbot

    Issue Status: 1. Open 2. Started 3. Submitted 4. Done


    This issue now has a funding of 10000.0 POLY (1499.0 USD @ $0.15/POLY) attached to it.

  2. gitcoinbot commented on Sep 21, 2018

    @gitcoinbot

    Issue Status: 1. Open 2. Started 3. Submitted 4. Done


    Work has been started.

    These users each claimed they can complete the work by 3 years, 4 months ago.
    Please review their action plans below:

    1) vyomshm has been approved to start work.

    I've been through the wireframe as well as the current Transfer Manager modules in the codebase.I'll structure this MaximumVolumeTransferManager contract/module in the same pattern.
    I'll implement the module itself as well as a factory contract for actually deploying the module.
    I'll write tests covering every bit of module functionality as well its deployment via the factory module.
    I'll update any relevant doc files + do a security check of new contracts via Mythril.

    Learn more on the Gitcoin Issue Details page.

  3. gitcoinbot commented on Sep 25, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  4. vyomshm commented on Sep 26, 2018

    @vyomshm

    Yes. I'll submit a WIP PR soon

  5. gitcoinbot commented on Sep 30, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  6. CPSTL commented on Oct 1, 2018

    @CPSTL
    ContributorAuthor

    @vyomshm Hello, just following up on when will you have a WIP PR by?

  7. gitcoinbot commented on Oct 1, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  8. vyomshm commented on Oct 1, 2018

    @vyomshm

    @CPSTL Yes, I'm still working on it. will submit a WIP PR in 3-4 days.

  9. vyomshm commented on Oct 5, 2018

    @vyomshm

    pre-empting gitcoin bot by posting this!

  10. gitcoinbot commented on Oct 9, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  11. gitcoinbot commented on Oct 10, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  12. vyomshm commented on Oct 10, 2018

    @vyomshm

    Yes

  13. vyomshm commented on Oct 13, 2018

    @vyomshm

    preempting gitcoin bot by posting this.

  14. vyomshm commented on Oct 15, 2018

    @vyomshm

    @CPSTL @satyamakgec Please review my PR #320

  15. gitcoinbot commented on Oct 15, 2018

    @gitcoinbot

    Issue Status: 1. Open 2. Started 3. Submitted 4. Done


    Work for 10000.0 POLY (1740.0 USD @ $0.17/POLY) has been submitted by:

    1. @vyomshm

    @CPSTL please take a look at the submitted work:


  16. gitcoinbot commented on Oct 25, 2018

    @gitcoinbot

    @vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

    • warning (3 days)
    • escalation to mods (6 days)

    Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

  17. vyomshm commented on Oct 26, 2018

    @vyomshm

    yes.

  18. gitcoinbot commented on Nov 12, 2018

    @gitcoinbot

    Issue Status: 1. Open 2. Started 3. Submitted 4. Done


    The funding of 10000.0 POLY (1740.0 USD @ $0.17/POLY) attached to this issue has been approved & issued to @vyomshm.

  19. satyamakgec commented on Jan 8, 2019

    @satyamakgec
    Contributor

    closing in the favor of #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Module developmentUsed when new module is createdopen-source communitySomething suggest or developed by external developers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions