You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Module Development Task: Volume Restriction (Maximum Volume Transfer) #267
21 days to complete once task is confirmed by external developer(s).
Short Summary:
For this module, ‘Maximum Volume Transfer’ we want to implement it in a way that you can only transfer a limited number of the total number of tokens within a certain time period.
Any token-holder can only transfer up to a maximum of 500,000 tokens in a 90 day period, regardless of the other restrictions (0.5% of the 100,000,000 tokens issued by the company). This applies to all token-holders and not just affiliated parties.
Note: This can be implemented as TM module with current architecture.
Bounty Requirements
Module specs are fulfilled
Module is implemented using appropriate module interface
Module is tested with >95% branch coverage
Module is delivered before deadline
Module does not present any bugs.
21 days to complete module from developers initial start date.
IMPORTANT: Please work from the development-1.5.0 branch instead of master.
Implementation Suggestion
I've been through the wireframe as well as the current Transfer Manager modules in the codebase.I'll structure this MaximumVolumeTransferManager contract/module in the same pattern.
I'll implement the module itself as well as a factory contract for actually deploying the module.
I'll write tests covering every bit of module functionality as well its deployment via the factory module.
I'll update any relevant doc files + do a security check of new contracts via Mythril.
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Activity
gitcoinbot commentedon Sep 21, 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 10000.0 POLY (1499.0 USD @ $0.15/POLY) attached to it.
gitcoinbot commentedon Sep 21, 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 3 years, 4 months ago.
Please review their action plans below:
1) vyomshm has been approved to start work.
I've been through the wireframe as well as the current Transfer Manager modules in the codebase.I'll structure this MaximumVolumeTransferManager contract/module in the same pattern.
I'll implement the module itself as well as a factory contract for actually deploying the module.
I'll write tests covering every bit of module functionality as well its deployment via the factory module.
I'll update any relevant doc files + do a security check of new contracts via Mythril.
Learn more on the Gitcoin Issue Details page.
gitcoinbot commentedon Sep 25, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
vyomshm commentedon Sep 26, 2018
Yes. I'll submit a WIP PR soon
gitcoinbot commentedon Sep 30, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
CPSTL commentedon Oct 1, 2018
@vyomshm Hello, just following up on when will you have a WIP PR by?
gitcoinbot commentedon Oct 1, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
vyomshm commentedon Oct 1, 2018
@CPSTL Yes, I'm still working on it. will submit a WIP PR in 3-4 days.
vyomshm commentedon Oct 5, 2018
pre-empting gitcoin bot by posting this!
gitcoinbot commentedon Oct 9, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
gitcoinbot commentedon Oct 10, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
vyomshm commentedon Oct 10, 2018
Yes
vyomshm commentedon Oct 13, 2018
preempting gitcoin bot by posting this.
vyomshm commentedon Oct 15, 2018
@CPSTL @satyamakgec Please review my PR #320
gitcoinbot commentedon Oct 15, 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work for 10000.0 POLY (1740.0 USD @ $0.17/POLY) has been submitted by:
@CPSTL please take a look at the submitted work:
gitcoinbot commentedon Oct 25, 2018
@vyomshm Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
vyomshm commentedon Oct 26, 2018
yes.
gitcoinbot commentedon Nov 12, 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
The funding of 10000.0 POLY (1740.0 USD @ $0.17/POLY) attached to this issue has been approved & issued to @vyomshm.
satyamakgec commentedon Jan 8, 2019
closing in the favor of #421