Repository navigation
Ship the German translation and complete it - #65
Merged
Merged
Conversation
resourceConfigurations only kept 'en', so values-de was stripped from every build since the Compose rewrite. German is now included, and the 41 missing strings plus the sort-order and theme label arrays are translated. GermanTranslationTest checks German is in the build, and TranslationCompletenessTest fails when an English string or label array has no German version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hameno
enabled auto-merge (rebase)
October 9, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourceConfigurations += ['en'](added in 476d177, "Implement JetPack Compose") strippedvalues-defrom every build, so German users have seen English only since then. This change:resourceConfigurationsis now['en', 'de']. This also brings in the German strings that Material components and AboutLibraries ship.sort_order_labels/theme_labelsarrays, using the informal "du" like the existing strings.GermanTranslationTest(Robolectric,dequalifier) checks German is in the build.TranslationCompletenessTestfails when a translatable English string or label array has no German version.Lint reports no issues in the changed files.
Not included: text hard-coded in Kotlin is still English (analytics opt-in dialog, "Select color", "Error", "Confirm", the delete-profile dialog, "Select option").
The translations were written by Claude, so a native speaker should skim them before release.
🤖 Generated with Claude Code