Skip to content

Ship the German translation and complete it - #65

Merged
hameno merged 1 commit into
masterfrom
feature/german_translations
Oct 9, 2026
Merged

hameno merged 1 commit into
masterfrom
feature/german_translations

Conversation

@hameno

@hameno hameno commented Oct 9, 2026

Copy link
Copy Markdown
Member

resourceConfigurations += ['en'] (added in 476d177, "Implement JetPack Compose") stripped values-de from every build, so German users have seen English only since then. This change:

  • Ships German: resourceConfigurations is now ['en', 'de']. This also brings in the German strings that Material components and AboutLibraries ship.
  • Completes the translation: adds the 41 missing strings and the sort_order_labels / theme_labels arrays, using the informal "du" like the existing strings.
  • Adds tests:
    • GermanTranslationTest (Robolectric, de qualifier) checks German is in the build.
    • TranslationCompletenessTest fails when a translatable English string or label array has no German version.

Lint reports no issues in the changed files.

Not included: text hard-coded in Kotlin is still English (analytics opt-in dialog, "Select color", "Error", "Confirm", the delete-profile dialog, "Select option").

The translations were written by Claude, so a native speaker should skim them before release.

🤖 Generated with Claude Code

resourceConfigurations only kept 'en', so values-de was stripped from
every build since the Compose rewrite. German is now included, and the
41 missing strings plus the sort-order and theme label arrays are
translated.

GermanTranslationTest checks German is in the build, and
TranslationCompletenessTest fails when an English string or label array
has no German version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hameno
hameno enabled auto-merge (rebase) October 9, 2026 21:09
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Test Results

34 tests  +4   34 ✅ +4   19s ⏱️ -9s
 7 suites +2    0 💤 ±0 
 7 files   +2    0 ❌ ±0 

Results for commit f6be5a0. ± Comparison against base commit 13f1d53.

@hameno
hameno merged commit b434a4c into master Oct 9, 2026
2 checks passed
@hameno
hameno deleted the feature/german_translations branch October 9, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant