Issue #154 - Create Military Families Page by mwagz · Pull Request #493 · OperationCode/operationcode_frontend

mwagz · 2017-09-10T04:52:48Z

This finalizes the Military Families and Spouses page as per Issue #154. This also adds the requirements for the clipping appearance as was represented in the mockup. This is a request from @hollomancer posted in the OperationCode Projects channel in Slack.

Issue Resolved

Fixes #154

mwagz · 2017-09-10T04:54:19Z


  setBgImage(location) {
-    if (location.pathname === '/') {
+    if (location.pathname === '/' || location.pathname === '/families') {


This can be removed if we don't want the BgImage on the families page.

We can leave it in here. I'll be fiddling with the Nav this weekend and this page isn't linked anywhere on the site.

While I'm in the Nav, I'll add a different image and try to set it up to dynamically choose a header image based upon route.

mwagz · 2017-09-10T04:56:54Z

+import React, { Component } from 'react';
+import styles from './headerClipMaskLeft.css';
+
+class HeaderClipMaskLeft extends Component {


This component and the HeaderClipMaskRight component will give us the clipping appearance we were seeing in the mockup. Not a big fan of this solution, but I think that if a browser doesn't support SVG, then it will simply not render it. Open to suggestions, but if it's too much of a hassle, I'll probably just remove it.

I actually like, but I'd go a step further and join Left and Right to just make HeaderClipMask for an import.

mwagz · 2017-09-10T04:57:40Z

-          <FaQuoteLeft className={styles.quoteIcon} />
-          {this.state.quote.body}
-          <FaQuoteRight className={styles.quoteIcon} />
+          &ldquo;{this.state.quote.body}&rdquo;


Mockup did not use Font Awesome quotes.

mwagz · 2017-09-10T05:06:48Z

              path="/about"
              component={About}
            />
+            <Route


Should we make this /about/families?

I think it should be it's own separate route because people will usually click it from the home page once we enable a link on the "Military Families and Spouses" card on the landing page.

kylemh

A lot of this is for thought. The definite changes I'd like to see:

Culmination of <QuoteBanner> and <JumboQuote> into a reusable component.
Culmination of Left and Right Clip Paths. Also, that breakpoint fix.
Decide on going bigger in global stylesheets or remaining the same. Regardless of the result, eliminate px sized fonts.
Left-align quote source.
Remove comments.

You matched the wireframe perfectly, but there's just some code smell to snub out.

kylemh · 2017-09-12T07:01:54Z

-  text-align: 'center';
+
+.factsHeading h2 {
+  font-size: 50px;


We're doing our best to avoid px sizing fonts. You'll see on src/index.css that we have a REM system that changes on break-points dynamically. I know that you we're aiming for the mock-up, and you matched it perfectly.

Try to balance what you've already got while choosing responsive text-sizes that make sense. This one in particular beats our h1 by 10 px on large screens - so it goes against our styles pretty heavily.

At the same token, perhaps we should up-size our text scale. Please feel free to start a debate on that in Slack. Sometimes I feel like the text on our site is too small.

If we're to scale our fonts up, we'll likely have some things break, but it'll be a good opportunity to wipe our project clean of all px sized fonts, and add a notch to the sustainable stylesheets belt.

Cleaned up the px font sizes in goals.css too.

kylemh · 2017-09-12T07:03:16Z

            </li>
          </ul>
+          <div className={styles.footnote}>
+            <span>*Source </span><strong>pointsofflight.org</strong>


Can you align this to the left edge of the quotes above it?

kylemh · 2017-09-12T07:12:54Z

+  position: relative;
+}
+
+@media screen and (max-width: 1700px) {


If you go with resizing the font's based upon our src/index.css global styles, you will likely be able to get rid of this whole media query.

Was able to get this effect by just removing this media query. So should be good.

kylemh · 2017-09-12T07:13:25Z

@@ -0,0 +1,39 @@
+import React, { Component } from 'react';
+// import family3 from '../../../images/Family-3.jpg';


Can you remove these comments?

kylemh · 2017-09-12T07:19:41Z

+import React, { Component } from 'react';
+import styles from './headerClipMaskLeft.css';
+
+class HeaderClipMaskLeft extends Component {


I actually like, but I'd go a step further and join Left and Right to just make HeaderClipMask for an import.

kylemh · 2017-09-12T07:20:30Z

@@ -0,0 +1,7 @@
+.mask {


instead of making these twice, just pull from an above headerClipMask.css since left and right styles are identical.

Couldn't do this exactly because they're not identical, but refactored the CSS to be more DRY.

kylemh · 2017-09-12T07:21:29Z


  setBgImage(location) {
-    if (location.pathname === '/') {
+    if (location.pathname === '/' || location.pathname === '/families') {


We can leave it in here. I'll be fiddling with the Nav this weekend and this page isn't linked anywhere on the site.

While I'm in the Nav, I'll add a different image and try to set it up to dynamically choose a header image based upon route.

kylemh · 2017-09-12T07:26:26Z

-
 .quotes {
  color: #445366;
+  max-width: 1100px;


Between these styles and the styles I wrote for shared/quoteBanner we've implemented styles for quotes twice. I think it may be useful to extract some mix of our styles into some kind of shared Quote component where we can pass props such as isHeader and hasLines.

You can see the <QuoteBanner> component in action on /team

kylemh · 2017-09-12T07:34:02Z

@@ -0,0 +1,7 @@
+.mask {


Seems as though between 700px and 800px the clip path creates space between the browser frame edge and the image edge.

Check this out, btw: https://stackoverflow.com/questions/34354770/curved-line-at-the-bottom-of-border-in-css

mwagz · 2017-09-13T13:28:03Z

@kylemh I'll be able to get to these changes sometime this weekend. Thanks for the review!

Cooperbuilt · 2017-09-27T17:14:10Z

@mwagz How are you doing with the changes?

mwagz · 2017-09-27T17:34:00Z

@Cooperbuilt I've had a really busy couple of weeks with work, but will be addressing these as soon as I'm able, which looks like sometime this week/weekend.

This finalizes the Military Families and Spouses page as per Issue OperationCode#154. This also adds the requirements for the clipping appearance as was represented in the mockup.

kylemh

One copy-pasta and a few more edits to the reusable component while you're in here!

Don't forget to link to the families page somewhere on landing - we want people to see your work!!

kylemh · 2017-10-03T08:12:44Z

+  width: 75%;
+}
+
 .factsRight {


I didn't want to give you more lame instructions on styles, so I made some final changes I'd like you to commit:

.factsRight { background-position: 70% 30%; border-radius: 40px; flex: 0.48; height: 50vh; margin-top: 65px; overflow: hidden; } .factItem { padding-bottom: 24px; } /* most mobile browsers have annoying behavior with vh on scroll */ @media screen and (max-width: 420px) { .factsRight { height: 300px; } }

I changed background-position simply because it seems to work well on my iPhone, laptop, and desktop with that setting.

kylemh · 2017-10-03T08:13:23Z

    "react-ga": "^2.2.0",
    "react-icons": "^2.2.5",
-    "react-modal": "^1.7.7",
+    "react-modal": "^2.3.2",


Thanks for this!

kylemh · 2017-10-03T08:21:47Z

@@ -5,7 +5,7 @@ import styles from './quoteBanner.css';
 class QuoteBanner extends Component {


We lost the gray background that worked well on /team and /history. Can you add an optional boolean prop for isDark. If isDark, the font should be white and the quoteBanner background should be the former steely gray. Once you've done that, you can throw isDark: true, onto line 89 of src/scenes/home/team/team.js.

kylemh · 2017-10-12T01:39:57Z

I'm going to close this due to inactivity. Feel free to open an updated PR with fixed conflicts and the requested changes!

mwagz commented Sep 10, 2017

View reviewed changes

kylemh suggested changes Sep 12, 2017

View reviewed changes

kylemh added the Status: On Hold label Sep 12, 2017

mwagz force-pushed the issue#154 branch from a9aa5b5 to 23af4f1 Compare October 2, 2017 00:11

Issue OperationCode#154 - Create Military Families Page

95e2472

This finalizes the Military Families and Spouses page as per Issue OperationCode#154. This also adds the requirements for the clipping appearance as was represented in the mockup.

mwagz force-pushed the issue#154 branch from 23af4f1 to 95e2472 Compare October 2, 2017 02:10

kylemh suggested changes Oct 3, 2017

View reviewed changes

kylemh reviewed Oct 3, 2017

View reviewed changes

kylemh added Status: In Progress Status: On Hold and removed Status: On Hold Status: In Progress labels Oct 3, 2017

kylemh closed this Oct 12, 2017

		@@ -0,0 +1,39 @@
		import React, { Component } from 'react';
		// import family3 from '../../../images/Family-3.jpg';

		@@ -5,7 +5,7 @@ import styles from './quoteBanner.css';
		class QuoteBanner extends Component {

Conversation

mwagz commented Sep 10, 2017

Issue Resolved

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kylemh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwagz Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwagz commented Sep 13, 2017

Uh oh!

Cooperbuilt commented Sep 27, 2017

Uh oh!

mwagz commented Sep 27, 2017

Uh oh!

kylemh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kylemh Oct 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kylemh commented Oct 12, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kylemh left a comment •

edited

Loading

mwagz Oct 2, 2017 •

edited

Loading

kylemh Oct 3, 2017 •

edited

Loading