Skip to content
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

Remove verification restriction for mentor requests #371

Merged
hpjaj merged 2 commits into from
Jul 11, 2018
Merged

Remove verification restriction for mentor requests #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0993e0f
Remove verification restriction for mentor requests
jjhampton Jul 1, 2018
ca11a01
Remove unneeded test cassette & folder
jjhampton Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/controllers/api/v1/airtable/mentorships_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ def index
end

def create
verify_user!

mentor_request = ::Airtable::Mentorship.new.create_mentor_request(mentorship_params)

render json: mentor_request, status: :created
Expand All @@ -33,10 +31,6 @@ def mentorship_params
:mentor_requested
)
end

def verify_user!
raise ::Airtable::Error, 'User must be verified to request mentor services' unless current_user.verified?
end
end
end
end
Expand Down
115 changes: 0 additions & 115 deletions ...hips_controller_test/_create_when_user_is_not_verified_it_returns_a_and_error_message.yml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions test/controllers/api/v1/airtable/mentorships_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,4 @@ class Api::V1::Airtable::MentorshipsControllerTest < ActionDispatch::Integration
assert response.parsed_body['createdTime'].present?
end
end

test ':create when user is not verified it returns a 422 and error message' do

@hpjaj hpjaj Jul 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also be able to delete/remove the associated cassette (and folder it is in, since it is the only file):

https://github.com/OperationCode/operationcode_backend/blob/master/test/cassettes/api_v_airtable_mentorships_controller_test/_create_when_user_is_not_verified_it_returns_a_and_error_message.yml

user = create(:user, verified: false)
headers = authorization_headers(user)

post(
api_v1_airtable_mentorships_url,
params: {},
headers: headers,
as: :json
)

assert response.status == 422
assert response.parsed_body['error'].present?
end
end