Repository navigation
Let FMPy record the variables of the reference - #399
Merged
Merged
Conversation
Without --output-variables, FMPy writes only the outputs of the model. diffSimulationResults gives success when a variable of the reference is not in the result, so master-fmi-fmpy compared only some variables, or none. In a sample of 800 verified rows of the 2026-11-06 run, 665 had variables that were not compared. Give FMPy the variables of the reference. FMPy ignores names that are not in the FMU. sh -c takes a command of at most 128 KiB, and some references have more names than that, so a longer list is left out. Assisted-by: Claude Opus 5.5
sjoelund
enabled auto-merge (squash)
November 6, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without --output-variables, FMPy writes only the outputs of the model. diffSimulationResults gives success when a variable of the reference is not in the result, so master-fmi-fmpy compared only some variables, or none. In a sample of 800 verified rows of the 2026-11-06 run, 665 had variables that were not compared.
Give FMPy the variables of the reference. FMPy ignores names that are not in the FMU. sh -c takes a command of at most 128 KiB, and some references have more names than that, so a longer list is left out.
Assisted-by: Claude Opus 5.5