Repository navigation
Give OMSimulator a step size when stopTime=startTime - #397
Merged
Merged
Conversation
For a model with stopTime=startTime the step size is 0. The testing
then does not pass --stepSize, and OMSimulator uses the stepSize of the
DefaultExperiment of the FMU, which is also 0. OMSimulator v3 refuses
it ("The stepSize must be greater than 0, but got 0.0"), so 104 rows of
master-fmi-cs-cvode (and the same in master-fmi) failed before the
simulation started. FMPy runs them.
There is no step in such a simulation, so give a step size of 1. Both
OMSimulator and FMPy then write the result at startTime.
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a model with stopTime=startTime the step size is 0. The testing then does not pass --stepSize, and OMSimulator uses the stepSize of the DefaultExperiment of the FMU, which is also 0. OMSimulator v3 refuses it ("The stepSize must be greater than 0, but got 0.0"), so 104 rows of master-fmi-cs-cvode (and the same in master-fmi) failed before the simulation started. FMPy runs them.
There is no step in such a simulation, so give a step size of 1. Both OMSimulator and FMPy then write the result at startTime.
Assisted-by: Claude Opus 5.5