Repository navigation
Conversation
Test 11 (from Reference-LAPACK PR 1410) compares the eigenvalues of xHSEQR with JOB = 'S' and JOB = 'E' by index. The two paths can return the eigenvalues in a different order, so a swap of two eigenvalues fails the test although the two lists agree. Compare each W1(j) with the nearest W3(i) instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6158,
make lapack-testwithTARGET=VORTEXM4reports one COMPLEX16 error:This is a false failure in the test, not in the kernels. Test 11 of
xCHKHS(from Reference-LAPACK PR 1410) compares the eigenvalues ofZHSEQRwithJOB = 'S'andJOB = 'E'by index. For this matrix the two lists hold the same 16 eigenvalues (to about 11 ulp), but eigenvalues 4 and 5 are in opposite order; the printed result is the distance between those two eigenvalues. All ZGEMM calls in the test are correct to rounding; the new kernels only round differently from reference BLAS. The same kind of swap, for well-conditioned eigenvalues (s about 0.5), gives the type 20 failure (result 11 is 1.363D+15) that a VORTEX build can show.The fix compares each
W1(j)with the nearestW3(i), in all four drivers. It is the same change as Reference-LAPACK/lapack#1491, which has the details and the eigenvalue data. This PR can also wait for that one to be merged upstream.Testing on Apple M4 (
TARGET=VORTEXM4, current develop):make lapack-test: 0 errors in all precisions (1 COMPLEX16 error before).nep.infor s, d, c and z: all pass.