Repository navigation
Fix duplicate file-log rotation in 1.6.0 - #329
Merged
TobiasRoeddiger merged 1 commit intoOct 5, 2026
Merged
TobiasRoeddiger merged 1 commit into
TobiasRoeddiger merged 1 commit into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit f30d981): https://open-earable-web--pr329-codex-shared-log-out-yteemedi.web.app (expires Mon, 02 Nov 2026 04:26:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/37264368957 |
TobiasRoeddiger
marked this pull request as ready for review
October 5, 2026 04:38
TobiasRoeddiger
merged commit Oct 5, 2026
d324cb1
into
automation/bump-version-1.5.4-36858743484
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app and library initialize the same file output twice, creating two rotation timers that race to rename
latest.log. This produced a caughtPathNotFoundExceptionduring a real firmware update. Give the shared output one initialization/destruction lifecycle and close both loggers when the manager is disposed.The actual file-output regression reproduces two timers and the rename error before the fix; afterward it verifies one timer, successful rotation, both log sources preserved exactly once and all timers cancelled on disposal. All 122 app tests pass and analysis is clean. The rebuilt app passed127 integrated tests, analysis and Android build. On the Pixel, the log viewer opened existing logs and displayed newly appended app and library messages; no file errors occurred. The rotation regression uses actual file I/O on the host; the phone did not reach its rotation threshold during this check.