Repository navigation
Sync partial moments, targets and dominance to R NNS 14.2 - #203
Closed
gitRasheed wants to merge 6 commits into
Closed
gitRasheed wants to merge 6 commits into
gitRasheed wants to merge 6 commits into
Conversation
OVVO-Financial
force-pushed
the
automation/r-cache-nns-14.2
branch
4 times, most recently
from
November 21, 2026 13:21
6c37081 to
bb05d3d
Compare
OVVO-Financial
pushed a commit
that referenced
this pull request
Nov 21, 2026
…ns-r14-parity-fidelity-rgag0e #200 and #203 both added src/nns/_r14_partial_moments.cpp: #200's is the vendor partial-moment overlay with the D.UPM fix, #203's the R 14.2 normalisation helpers for the nD moments and PM.matrix. #200's keeps the name; #203's becomes src/nns/_r14_pm_norm.{cpp,hpp}. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wws6NpuQ72C5sfEYVoVmGt
OVVO-Financial
pushed a commit
that referenced
this pull request
Nov 21, 2026
…-14.2 The builder's regeneration (bb05d3d) and this branch's agree on every shared cache entry. This branch's cache adds the entries for tests the builder's run did not have (the merged #203 tests, the meboot helpers and the new 14.2 contracts), so the resolution keeps this branch's tree unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wws6NpuQ72C5sfEYVoVmGt
OVVO-Financial
pushed a commit
that referenced
this pull request
Nov 21, 2026
- r_commit f0387ed and NNS_14.2.tar.gz as stored there (sha256 a4e04b26...), the archive the cache builder downloads; its R/ and src/ files equal the Git tree apart from CRLF line endings and final newlines. - The central-tendency and M.reg prediction overlays now port f0387ed's sources. The dependence and D.UPM overlays keep their source commits: R 14.2 changes those files only in label ordering and the zero-total rule. - #203's normalisation helper is tracked under its new name, src/nns/_r14_pm_norm.cpp, beside #200's D.UPM overlay, so there are six overlays, all verified against f0387ed. - Cache summary: 150 shards, 3124 entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wws6NpuQ72C5sfEYVoVmGt
4 of 5 tasks
Owner
|
Closing as superseded. All six commits on this branch, from The normalisation helper is on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm targeting the cache-refresh branch of #201 (
b184171c) and syncing Python to R NNS 14.2 at31291970.Nonetarget. With excess returns,lpm(1, None, [1, 2, 3, 10], True)returns 1.5. A nonfinite target raises before a bad degree.Decimal. A date counts days. NumPy datetimes and pandas timestamps keep their unit, so a target two seconds after the epoch giveslpm_ratioof 0.5 for degree 1 and data[0, 2, 4].pm_matrixaccepts"mean"and"means"for column means, including a one-element Series with index 0. It reads matrix targets by column. For four columns,[[1, 3], [2, 4]]supplies 1, 2, 3, 4.[0, inf]against[0, 1]it returns 1. Continuous FSD, SSD and TSD reject infinity.I kept Python's documented scalar broadcast in
pm_matrix. A target of 0 applies to every column. R NNS 14.0 and 14.2 both reject a single numeric target for multiple columns.I compared 4,438 native calls and 4,390 NumPy calls with live R and found zero regressions against #201. CI needs #202 to go green.