Skip to content

[16.0][FIX] base_import_async: use chunk size defined by user in front when creating import batches - #878

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:zra-fix-chunk
Feb 4, 2026
Merged

OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:zra-fix-chunk

Conversation

@AnizR

@AnizR AnizR commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Goal

Define the chunk size when importing in background

Context

When realizing big import, we have the option to define batch sizes for import (feature from odoo's base_import):
image

But, I realized that base_import_async wasn't using this field and so, it does only batches of 100 records (default value).
This field is set as options["limit"] by odoo's front (in .js). Therefore, I have updated the OPT_CHUNK_SIZE because "chunk_size" is never defined.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul

sbidoul commented Feb 4, 2026

Copy link
Copy Markdown
Member

Looks good. Thanks!

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-878-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@sbidoul The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-878-by-sbidoul-bump-patch:16.0 failed with output:

To https://github.com/OCA/queue
 ! [rejected]          16.0-ocabot-merge-pr-878-by-sbidoul-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://github.com/OCA/queue'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot
OCA-git-bot merged commit 3f8dd30 into OCA:16.0 Feb 4, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 545c5bc. Thanks a lot for contributing to OCA. ❤️

@sbidoul
sbidoul deleted the zra-fix-chunk branch February 4, 2026 13:12
@AnizR AnizR mentioned this pull request Jun 17, 2026
1 task done
petrus-v added a commit to petrus-v/queue that referenced this pull request Jun 19, 2026
parabol123654 added a commit to parabol123654/queue that referenced this pull request Nov 14, 2026
…chunk size

The import dialog sends the batch size as options["limit"], but the
module read options["chunk_size"], which nothing sends. Background
imports were always split in chunks of 100 lines.

Port of OCA#878 (16.0).

Assisted-by: Claude Opus 5.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants