Skip to content

[16.0] Remove doctest from get_db_names method to avoid issues with Odoo.sh - #609

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
AlexanderPashuk:16.0
Jan 8, 2024
Merged

OCA-git-bot merged 1 commit into
OCA:16.0from
AlexanderPashuk:16.0

Conversation

@AlexanderPashuk

Copy link
Copy Markdown
Contributor

This is the hotfix for this issue: #608

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree tests should not rely on a specific database name. So ok to remove this test for now (it was added recently in #580).

@gurneyalex

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-609-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 8, 2024
Signed-off-by gurneyalex
@OCA-git-bot

Copy link
Copy Markdown
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-609-by-gurneyalex-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit a007e17 into OCA:16.0 Jan 8, 2024
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f5a8854. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants