Repository navigation
[19.0][FIX] document_url: keep chatter at top when opening attachments - #665
Open
marketingorganoid-source wants to merge 1 commit into
Open
marketingorganoid-source wants to merge 1 commit into
marketingorganoid-source wants to merge 1 commit into
Conversation
The chatter renders its thread with order="desc". There a numeric thread.scrollTop is read as the distance from the end, so setting it to 0 made the chatter jump to the oldest message as soon as the thread recomputed its scroll (image loaded, resize). Use "bottom" like core mail does, which means the top for a descending thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Cause
url.esm.jsoverridesChatter.onClickAddAttachmentsand setsthis.state.thread.scrollTop = 0. The chatter renders the thread withorder="desc", and thereThread.applyScrollreads a numericscrollTopas the distance from the end (scrollHeight - scrollTop - clientHeight), so0means "bottom of the list".Fix
Use
"bottom"like core mail does inonClickAddAttachments, which for a descending thread means the top (newest message).Reproduced on Odoo 19.0 with document_url 19.0.1.0.0: chatter scrollTop went from 0 to the maximum after opening the attachment box; with this change it stays at 0.
🤖 Generated with Claude Code