Dashboard isModified setting for tags

[dwertheimer]

When you get a few moments, can you have a look at this?

I have a perspective called ALL_ON that has every item enabled and a bunch of tags in it.

About half the time that I switch to this perspective, without making any changes, I see it think it's modified:

Log says:

JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged: Setting perspective.isModified because of changes to settings: 7 keys: showTagSection_#dbwDR, showTagSection_#waiting, showTagSection_@pierce, showTagSection_@kenna, showTagSection_@anique, showTagSection_@bev, showTagSection_@storey :: {
  "showTagSection_#dbwDR": true,
  "showTagSection_#waiting": true,
  "showTagSection_@pierce": true,
  "showTagSection_@kenna": true,
  "showTagSection_@anique": true,
  "showTagSection_@bev": true,
  "showTagSection_@storey": true
}
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#dbwDR']=undefined vs. sent to save: cleanedSettings['showTagSection_#dbwDR']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#waiting']=undefined vs. sent to save: cleanedSettings['showTagSection_#waiting']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@pierce']=undefined vs. sent to save: cleanedSettings['showTagSection_@pierce']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@kenna']=undefined vs. sent to save: cleanedSettings['showTagSection_@kenna']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@anique']=undefined vs. sent to save: cleanedSettings['showTagSection_@anique']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@bev']=undefined vs. sent to save: cleanedSettings['showTagSection_@bev']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@storey']=undefined vs. sent to save: cleanedSettings['showTagSection_@storey']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Setting isModified to true for perspective z_ALL_ON
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Saving perspectiveSettings also

The front-end is sending all the TAG sections as true (which is correct), but the variable activePerspDefDashboardSettingsWithDefaults is not including those TAGs and therefore they don't match. So somewhere/somehow that activePerspDefDashboardSettingsWithDefaults needs to include the TAG sections so that the comparison works properly.

Can you please have a look?

[jgclark]

I think I follow, so I've changed the code in doDashboardSettingsChanged() accordingly:

  //    vvv Added
  // Now add all the TAG sections, which otherwise aren't included in the active perspective settings.
        // Get any active perspective setting keys that start 'showTagSection_'
        const activePerspDefShowTagSectionKeys = Object.keys(activePerspDef.dashboardSettings).filter((k) => k.startsWith('showTagSection_'))
        clo(activePerspDefShowTagSectionKeys, `doDashboardSettingsChanged: activePerspDefShowTagSectionKeys`)
        // Add all the TAG sections to the active perspective settings
        const activePerspDefDashboardSettingsWithDefaultsAndTAGs = { ...activePerspDefDashboardSettingsWithDefaults, ...activePerspDefShowTagSectionKeys }
  //    ^^^

        // Compare the cleaned settings with the active perspective settings
        const diff = compareObjects(activePerspDefDashboardSettingsWithDefaultsAndTAGs, cleanedSettings, ['lastModified', 'lastChange', 'usePerspectives'])
        clo(diff, `doDashboardSettingsChanged: diff`)

[jgclark]

Please test this fix, @dwertheimer. Pushing branch to main shortly.