ci(release): stop expecting sbg in the classic framework - #22
Merged
Merged
Conversation
template/build.ps1 no longer builds sbg (removed in #21: the bridge emits JS subclass types at runtime), so the output check failed the classic build on the missing sbg-x64/arm64.exe.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
npm releaserun after #21 merged (run 37182021860) failed in Build classic framework:#21 removed sbg from
template/build.ps1because the bridge now emits JS subclass types at runtime, but the workflow's output check still listed it. This dropssbgfrom that list and from the comment describing the classic build. All other outputs (runtime DLLs, devtools DLLs and the remaining tools) were built in that run. The other engine builds passed.