test: skip CUDA-GL interop tests when the GL context is not on an NVIDIA GPU - #2986
Open
IvanGrigorik wants to merge 3 commits into
Open
IvanGrigorik wants to merge 3 commits into
IvanGrigorik wants to merge 3 commits into
Conversation
Contributor
github-actions
Bot
added
cuda.bindings
Contributor
|
/ok to test d10a7c3 |
Contributor
|
/ok to test d10a7c3 |
Contributor
|
juenglin
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2985
The CUDA-GL interop tests fail with
CUDA_ERROR_UNKNOWNwhen the current GL context is on a GPU from another vendor, for example on a hybrid-graphics laptop whose display is driven by a non-NVIDIA iGPU. CUDA-GL interop needs the context to be on an NVIDIA GPU, and the generic error the driver returns can't be told apart from a real failure at the call site. So instead of catching it, the tests now check the context up front and skip.New tests and old tests verification
On a hybrid laptop (RTX 3050 Ti + AMD Cezanne iGPU, driver 595.84, CUDA 13.3):
DISPLAYset to non-NVIDIA GPU:test_graphics_apis.pygives 1 passed, 2 skipped, andtest_graphics.py+test_helpers.pygive 53 passed, 24 skipped. Skips reportGL context is not on an NVIDIA GPU (GL_VENDOR='...', ...). Before this change, the same runs had 2 + 24 failures.DISPLAYunset (headless EGL, context on NVIDIA): 3 passed and 77 passed, with no skips, so the interop path is still exercisedChecklist