Skip to content

Enables automatic CodeRabbit reviews for pull requests targeting main.Description - #2958

Merged
jpascucci-nv merged 5 commits into
NVIDIA:mainfrom
jpascucci-nv:issue2137
Oct 5, 2026
Merged

jpascucci-nv merged 5 commits into
NVIDIA:mainfrom
jpascucci-nv:issue2137

Conversation

@jpascucci-nv

@jpascucci-nv jpascucci-nv commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Addresses #2137 rollout steps 1 and 2.

Description

The new .coderabbit.yaml is based on CCCL’s low-noise configuration and adapts its review guidance to cuda-python’s packages and workflows. It:

  • Uses the chill review profile with brief, severity-prefixed comments.
  • Disables walkthrough/status noise, finishing-touch suggestions, and pre-merge checks.
  • Skips drafts and PRs authored by repository automation bots.
  • Enables Gitleaks, markdownlint, and ShellCheck.
  • Adds focused review instructions for cuda-bindings, cuda-core, cuda-pathfinder, the cuda-python metapackage, benchmarks, CI, GitHub automation, and Cython sources.
  • Uses the repository’s existing AGENTS.md, contribution guides, package documentation, and release-note indexes as review context.

Automatic reviews are intentionally limited to main. CodeRabbit and Greptile will initially run together so their signal, noise, and overlap can be evaluated on real PRs before expanding CodeRabbit to backport branches or changing either reviewer’s configuration.

Testing

  • Parsed .coderabbit.yaml successfully.
  • Ran YAML linting.
  • Verified the SPDX header.
  • Verified every configured knowledge-base file exists.
  • Verified auto-review is enabled only for main.
  • Ran git diff --check.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jpascucci-nv jpascucci-nv added this to the cuda.core 1.3.0 milestone Sep 28, 2026
@jpascucci-nv jpascucci-nv self-assigned this Sep 28, 2026
@jpascucci-nv jpascucci-nv added the CI/CD CI/CD infrastructure label Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For deterministic checks (gitleaks, markdownlint, shellcheck) what is the advantage of doing that with coderabbit vs. precommit hooks? precommit hooks are great because they run quickly and locally before committing... it seems like a step back to do them later in CodeRabbit instead.

@jpascucci-nv

Copy link
Copy Markdown
Contributor Author

For deterministic checks (gitleaks, markdownlint, shellcheck) what is the advantage of doing that with coderabbit vs. precommit hooks? precommit hooks are great because they run quickly and locally before committing... it seems like a step back to do them later in CodeRabbit instead.

@mdboom I think your comment should be directed to @rparolin, who specified those settings, I don't have an answer .

Comment thread .coderabbit.yaml Outdated
Comment thread .coderabbit.yaml Outdated
@rparolin

rparolin commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

For deterministic checks (gitleaks, markdownlint, shellcheck) what is the advantage of doing that with coderabbit vs. precommit hooks? precommit hooks are great because they run quickly and locally before committing... it seems like a step back to do them later in CodeRabbit instead.

@mdboom I think your comment should be directed to @rparolin, who specified those settings, I don't have an answer .

When my agent analyzed CCCLs setup thats where those settings came from. So if there is a specific reason why they work for CCCL and wouldn't work for cuda-python then fine lets remove them. The issue write up was intended to be a starting place and not overly prescriptive of what the landed solution should be. However, I would love to see an articulated argument of why we are deviating from CCCLs setup and why that doesn't work for us?

Enables automatic CodeRabbit reviews for pull requests targeting `main`.

The new `.coderabbit.yaml` is based on CCCL’s low-noise configuration and adapts its review guidance to cuda-python’s packages and workflows. It:

- Uses the `chill` review profile with brief, severity-prefixed comments.
- Disables walkthrough/status noise, finishing-touch suggestions, and pre-merge checks.
- Skips drafts and PRs authored by repository automation bots.
- Enables Gitleaks, markdownlint, and ShellCheck.
- Adds focused review instructions for cuda-bindings, cuda-core, cuda-pathfinder, the cuda-python metapackage, benchmarks, CI, GitHub automation, and Cython sources.
- Uses the repository’s existing `AGENTS.md`, contribution guides, package documentation, and release-note indexes as review context.

Automatic reviews are intentionally limited to `main`. CodeRabbit and Greptile will initially run together so their signal, noise, and overlap can be evaluated on real PRs before expanding CodeRabbit to backport branches or changing either reviewer’s configuration.

Testing

- Parsed `.coderabbit.yaml` successfully.
- Ran YAML linting.
- Verified the SPDX header.
- Verified every configured knowledge-base file exists.
- Verified auto-review is enabled only for `main`.
- Ran `git diff --check`.
@mdboom

mdboom commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

For deterministic checks (gitleaks, markdownlint, shellcheck) what is the advantage of doing that with coderabbit vs. precommit hooks? precommit hooks are great because they run quickly and locally before committing... it seems like a step back to do them later in CodeRabbit instead.

@mdboom I think your comment should be directed to @rparolin, who specified those settings, I don't have an answer .

When my agent analyzed CCCLs setup thats where those settings came from. So if there is a specific reason why they work for CCCL and wouldn't work for cuda-python then fine lets remove them. The issue write up was intended to be a starting place and not overly prescriptive of what the landed solution should be. However, I would love to see an articulated argument of why we are deviating from CCCLs setup and why that doesn't work for us?

No objection to putting these linters in cuda-python. It just seems nonsensical to put deterministic linting into a non-deterministic agent-driven review. It's a step back -- precommit runs locally and quickly on every commit. CodeRabbit is slow and non-deterministic. cuda-python has historically put linters into pre-commit, and I think we should continue to do that.

@jpascucci-nv jpascucci-nv added the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Oct 5, 2026

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jpascucci-nv
jpascucci-nv merged commit 87942b2 into NVIDIA:main Oct 5, 2026
118 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 6, 2026
Removed preview folders for the following PRs:
- PR #2958
- PR #2963
- PR #2978
- PR #2988
- PR #2999
- PR #3000
- PR #3006
- PR #3011
- PR #3013
- PR #3019
- PR #3020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants