Repository navigation
feat(helm)!: require opt-in for gateway service routing - #5672
Merged
TaylorMutch merged 6 commits intoNov 19, 2026
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5672.docs.buildwithfern.com/openshell |
TaylorMutch
force-pushed
the
feat/5671-helm-service-routing-opt-in/TaylorMutch
branch
from
November 18, 2026 05:50
c6e1b4f to
f947299
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
2 times, most recently
from
November 18, 2026 20:14
1e069a1 to
5500740
Compare
TaylorMutch
force-pushed
the
feat/5671-helm-service-routing-opt-in/TaylorMutch
branch
2 times, most recently
from
November 19, 2026 00:08
218251a to
89d6566
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
November 19, 2026 00:08
5500740 to
f8d1af1
Compare
TaylorMutch
force-pushed
the
feat/5671-helm-service-routing-opt-in/TaylorMutch
branch
from
November 19, 2026 18:01
89d6566 to
8be9e6c
Compare
TaylorMutch
force-pushed
the
feat/4953-authoritative-app-urls/TaylorMutch
branch
from
November 19, 2026 18:01
f8d1af1 to
70d7bdc
Compare
Base automatically changed from
feat/4953-authoritative-app-urls/TaylorMutch
to
main
November 19, 2026 18:41
BREAKING CHANGE: Helm installations relying on gateway service URLs must explicitly set gatewayConfig."openshell.gateway".service_routing_enabled to true before upgrading. Core and non-Kubernetes defaults remain unchanged. Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
force-pushed
the
feat/5671-helm-service-routing-opt-in/TaylorMutch
branch
from
November 19, 2026 18:51
8be9e6c to
443fc7d
Compare
TaylorMutch
marked this pull request as ready for review
November 19, 2026 18:52
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. helm — No explicit risk acceptance foundThe Experimental Helm chart changes gatewayConfig."openshell.gateway".enable_gateway_service_routing from an implicit true default to false, including saved values that omit the setting.
Review details
Advisory review; publication gates are unchanged. |
pimlock
previously approved these changes
Nov 19, 2026
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
pimlock
approved these changes
Nov 19, 2026
TaylorMutch
enabled auto-merge
November 19, 2026 21:34
TaylorMutch
deleted the
feat/5671-helm-service-routing-opt-in/TaylorMutch
branch
November 19, 2026 22:10
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default Kubernetes Helm deployments to disabling gateway-mediated sandbox service routing, avoiding an unintended alternate application access path when operators use dedicated application ingress. The core runtime keeps its enabled default, preserving Docker, Podman, and VM behavior outside this chart.
Upgrade action: Helm installations relying on gateway service URLs must explicitly retain forwarding:
Based on main at
90e34ad10. This changes Helm behavior independently of gateway application authentication.Related Issue
Closes #5671.
Changes
enable_gateway_service_routing = falseby default, including saved values that omit the setting or set it to null; preserve explicit boolean choices.[openshell.supervisor.app_listener].enabled = trueplus an ingress solution that routes discovered hostnames to the owning supervisor app-listener endpoint. Usebase_urlas the only application origin, with its domain derived automatically. Include the Helm/TLS configuration example, explicit gateway opt-in, and upgrade setting.Testing
90e34ad10after feat(services): publish authoritative application origins #4956 merged. Each PR's patch is unchanged; stack ancestry and absence of Go/frozen Python SDK changes verified.No live-cluster E2E was rerun for this rebase. Current-head GitHub CI is pending.
Release Notes
Kubernetes Helm deployments now require an explicit opt-in for gateway-mediated sandbox service URLs and HTTP/WebSocket forwarding. Set
gatewayConfig."openshell.gateway".enable_gateway_service_routing: truebefore upgrading if you rely on that path. The core and non-Kubernetes defaults are unchanged.